Don't make binaryDirExpanded relative #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's made relative to nvim's cwd, not config.cwd and furthermore there is no point in making it relative in the first place.
Osse
force-pushed
the
dont-relativize
branch
from
7c4c116 to
e87b739
Compare
|
@lceWolf Can you review this? |
|
I think it is fine to omit making it relative. If an absolute path is given, it should be used as is. Only if the binaryDir is given as relative it should be treated relative to the source dir. Transforming the absolute path into a relative one and concatenating this with |
|
Thanks for fixing that - good catch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's made relative to nvim's cwd, not config.cwd and furthermore there is no point in making it relative in the first place.