Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-23429] merge insights-controller into main chart #117

Merged
merged 17 commits into from
Dec 10, 2024
Merged

Conversation

dmepham
Copy link
Collaborator

@dmepham dmepham commented Dec 6, 2024

Description

There isn't a lot of benefit to having a subchart in the cloudzero-agent chart now that they're always used together. this PR does two things:

  1. merges the insights-controller chart into the cloudzero-agent chart, and
  2. renames the tags map to insightsController

todo

  • webhooks should be created based on resource enablement, not if they exist in the webhooks array
  • insightsController.enabled should turn off all related components
  • update documentation to reflect tags -> insightsController name change

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@dmepham dmepham requested a review from a team as a code owner December 6, 2024 21:56
@@ -12,7 +12,7 @@ global:
existingSecretName: null

# label and annotation configuration:
tags:
insightsController:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm making this change because I want to make sure that we choose a name that will make sense for future changes. the insights-controller can potentially handle much more than labels and annotations, so I don't want to add a confusing name.
the downside is that this is less descriptive for users who are looking to configure labels/annotations

@dmepham dmepham changed the base branch from release/1.0.0 to release-1.0.0-beta December 9, 2024 22:26
@dmepham dmepham changed the base branch from release-1.0.0-beta to release/1.0.0 December 9, 2024 22:26
@josephbarnett josephbarnett mentioned this pull request Jan 9, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants