-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-23429] merge insights-controller into main chart #117
Conversation
@@ -12,7 +12,7 @@ global: | |||
existingSecretName: null | |||
|
|||
# label and annotation configuration: | |||
tags: | |||
insightsController: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making this change because I want to make sure that we choose a name that will make sense for future changes. the insights-controller can potentially handle much more than labels and annotations, so I don't want to add a confusing name.
the downside is that this is less descriptive for users who are looking to configure labels/annotations
Description
There isn't a lot of benefit to having a subchart in the cloudzero-agent chart now that they're always used together. this PR does two things:
tags
map toinsightsController
todo
Checklist
main