Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-22731: add insights-controller chart #97

Merged
merged 31 commits into from
Nov 14, 2024
Merged

Conversation

dmepham
Copy link
Collaborator

@dmepham dmepham commented Nov 11, 2024

By submitting a PR to this repository, you agree to the terms within the CloudZero Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

  • Adds the insights-controller chart
  • Adds the insights-controller as a subchart to the cloudzero-agent chart. to be released as 1.0.0-beta
  • Updates documentation to force user to choose labels preferences
  • Removes node-exporter as dependency

Testing

  1. ensured chart can be installed and complete standard functions
  2. ensured insights-controller can still be install individually
  3. testing input validation:
release "cloudzero-agent" does not exist. Installing it now.
Error: execution error at (cloudzero-agent/charts/tags/templates/config.yaml:13:4):


The required field(s) 'labels.enabled' and/or 'labels.patterns' is missing or not set! See the README.md for more information.
 Ensure that 'labels.enabled' is a boolean (true or false). Set 'true' to enable exporting labels.
 The required field 'labels.patterns' is missing or not set. It must be an array of regular expressions that match label keys to be exported.

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@dmepham dmepham requested a review from a team as a code owner November 11, 2024 22:32
condition: prometheus-node-exporter.enabled
- name: cloudzero-insights-controller
version: "0.0.1"
repository: https://cloudzero.github.io/cloudzero-charts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use the beta channel for now? Not sure if we need to add the --devel flag somehow

@josephbarnett josephbarnett self-requested a review November 12, 2024 18:15
@josephbarnett
Copy link
Contributor

josephbarnett commented Nov 12, 2024

We may want to create a beta branch to serve in place of main so we don't mix beta and stable release code. Thoughts?

@conradcz @adamrice32

CP-TICKET BRANCH ------------->>
                               |
BETA---------------------------+------------->> BETA RELEASES COME FROM HERE
                               |
DEV----------------------------+------------->> APPROVED FEATURES OR BUG FIXES
                               |
MAIN---------------------------+------------->> RELEASE OR OUT OF BETA RELEASES

@dmepham
Copy link
Collaborator Author

dmepham commented Nov 12, 2024

@josephbarnett I'm up for it

@dmepham dmepham changed the base branch from develop to release-beta November 12, 2024 18:43
Copy link
Contributor

@wreckedred wreckedred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - lgtm

@dmepham dmepham changed the base branch from release-beta to feature/1.0.0-beta-release November 14, 2024 01:37
Comment on lines +15 to +19
- name: cloudzero-insights-controller
version: "0.0.1"
repository: https://cloudzero.github.io/cloudzero-charts/beta
condition: cloudzero-insights-controller.enabled
alias: tags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we cut this first version, let's double check this is replaced correctly with the sed command in the release CI/CD job

@dmepham dmepham merged commit 1a7a45c into feature/1.0.0-beta-release Nov 14, 2024
2 of 3 checks passed
@dmepham dmepham deleted the CP-22731 branch November 14, 2024 12:15
dmepham added a commit that referenced this pull request Nov 21, 2024
* CP-22731: include cz-insights-controller as subchart

* increase replicacount for tag server

* CP-22731: add beta testing

* update release process for insights controller

* update release workflow

* make most resources off by default

* update readme

* use global for secret names

* incorporate changes from 0.0.30-beta

* add beta release doc

* use local chart for testing

---------

Co-authored-by: josephbarnett <[email protected]>
@josephbarnett josephbarnett mentioned this pull request Jan 9, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants