Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update readme #878

Merged
merged 2 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ The principles that we believe in are:
Installation
------------

**WARNING**: It is **NOT** recommended to create the database using the db:migrate command during the installation process. Some migrations in the project have become outdated due to Rails updates during the application's development. Therefore, if you create the database from scratch using these outdated migrations instead of loading the current schema, the application will not function as intended, and some tests will fail. Be aware!

First up, your system will need the
[prerequisites for running Ruby on Rails installed](https://guides.rubyonrails.org/getting_started.html)
Once you have these:
Expand Down Expand Up @@ -135,9 +137,7 @@ Or using docker:
# Prepare container
$ docker compose build
$ docker compose run --rm web yarn install
$ docker compose run --rm web bundle exec rake db:create
$ docker compose run --rm web bundle exec rake db:migrate
$ docker compose run --rm web bundle exec rake db:seed
$ docker compose run --rm web bundle exec rake db:setup

# Up container
$ docker compose up
Expand Down
2 changes: 1 addition & 1 deletion app/models/project.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Project < ApplicationRecord
has_many :integrations, dependent: :destroy
has_many :changesets, dependent: :destroy
has_many :integrations, dependent: :destroy
has_many :ownerships
has_many :ownerships, dependent: :destroy
has_many :teams, through: :ownerships
has_many :memberships, dependent: :destroy
has_many :users, -> { distinct }, through: :memberships
Expand Down
1 change: 1 addition & 0 deletions spec/models/project_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@
subject { build :project }
it { is_expected.to belong_to(:tag_group) }
it { is_expected.to have_many(:changesets) }
it { is_expected.to have_many(:ownerships).dependent(:destroy) }
end

describe '#as_json' do
Expand Down
Loading