perf: 2x speed up reading contents from zip/jar #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This specific optimistaions is targeted towards JVM Class resources, in is isAsmCompliantClass we would read the class and check for custom attributes, then we would read the class again to build the class info in this pr I merged the functionality of isASMCompliantClass into ClassBuilderAppender
1fxe
force-pushed
the
improve-import-speed
branch
from
15f3790 to
127989f
Compare
1fxe
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev4 #761 +/- ##
============================================
- Coverage 66.85% 66.85% -0.01%
+ Complexity 2410 2406 -4
============================================
Files 323 322 -1
Lines 13934 13925 -9
Branches 1584 1584
============================================
- Hits 9316 9309 -7
+ Misses 3896 3894 -2
Partials 722 722 ☔ View full report in Codecov by Sentry. |
|
I oughta look into keeping codecov but not having it "fail" the build... |
1fxe
force-pushed
the
improve-import-speed
branch
from
5281ac4 to
0bef105
Compare
1fxe
commented
Jan 19, 2024
recaf-core/src/main/java/software/coley/recaf/workspace/io/BasicInfoImporter.java
Outdated
Show resolved
Hide resolved
Changed flag to skipCustomAttributeChecks and made it true by default since we should only be checking this from InfoImporter, we should be ignoring for jvm bundles for example. Also added back the skipASMValidation check to make sure parity is the same
1fxe
force-pushed
the
improve-import-speed
branch
from
0bef105 to
211b9d1
Compare
Col-E
reviewed
Jan 19, 2024
recaf-core/src/main/java/software/coley/recaf/workspace/io/BasicInfoImporter.java
Show resolved
Hide resolved
Col-E
force-pushed
the
improve-import-speed
branch
from
11894f1 to
9a8a032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specific optimistaions is targeted towards JVM Class resources, in is isAsmCompliantClass we would read the class and check for custom attributes, then we would read the class again to build the class info in this pr I merged the functionality of isASMCompliantClass into ClassBuilderAppender
What's new
Before ~ 5746ms on a 100mb jar
After ~ 2823ms
