Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Anomaly DLC #3105

Merged
merged 70 commits into from
Jun 21, 2024
Merged

Patch Anomaly DLC #3105

merged 70 commits into from
Jun 21, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Apr 23, 2024

Additions

Dummy PR for tracking/testing purposes.

  • Patch new Anomaly content to work with CE.

Changes

  • TBD

References

Related to #3024

Reasoning

  • Because the Cube wills it.

Alternatives

None, really.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners April 23, 2024 22:53
@N7Huntsman N7Huntsman marked this pull request as draft April 23, 2024 22:53
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8808256338.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Apr 23, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8808275261.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8809214818.zip

Copy link

github-actions bot commented Jun 9, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9440377170.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9446152180.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9459750961.zip

MaxDorob
MaxDorob previously approved these changes Jun 11, 2024
Copy link
Contributor

@MaxDorob MaxDorob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9492356836.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9492527032.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9492759877.zip

@SamaelGray
Copy link
Contributor

Crossbow bolts and crossbows themselves like the Spiker are commonly considered medieval, wouldn't it be more appropriate for the Spike bolts' (bioferrite arrows(?) bolts) texture path to be inside the Medieval folder?

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9511181882.zip

Copy link
Contributor

@Tostov Tostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems workable, haven't run into any major bug issues from a decent amount of colony time (haven't tested all events in regular play but most have been completed in devmode quickly testing).
Entity downing seems to be a little odd since a lot of them tend to go down very quickly but just barely, and often get back up shortly afterwards. But otherwise not problematic as far as I have experienced.
As noted in the other note, noctol just needs its add changed to a replace and then I can't see any other specific issues with operation of the branch/patch.
Gorehulks/fleshbeasts/sightstealers/rev/human shamblers/ghouls/metalhorrors have all worked fine in normal play.

Further testing completed. Shape flesh ability does not work.

Anomaly/Patches/ThingDefs_Races/Races_Entities_Misc.xml Outdated Show resolved Hide resolved
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9589489247.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9590389041.zip

Copy link
Contributor

@Tostov Tostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deadlife pack currently does not consume charges.
In vanilla it is single use and disposable.
I'm not sure if we have a one use variant of the static launch verb we use on apparel.
If not we could just force it to use/reload with deadlife shells, which is sensible but does significantly increase the power of the pack (and consequentely reduce the effective strength of the creep joiner that has the deadlife ability).

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9606445899.zip

@Tostov
Copy link
Contributor

Tostov commented Jun 21, 2024

All tested equipment/abilites seem to be working without issues now. Able to complete a playthrough without any gamebreaking issues arising outside of those now resolved.

@N7Huntsman N7Huntsman merged commit 22c24fc into Development Jun 21, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the Anomaly-DLC branch June 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants