Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP factors #3134

Merged
merged 12 commits into from
Jun 11, 2024
Merged

AP factors #3134

merged 12 commits into from
Jun 11, 2024

Conversation

MaxDorob
Copy link
Contributor

@MaxDorob MaxDorob commented May 12, 2024 •
edited
Loading

Additions

Describe new functionality added by your code, e.g.

  • melee AP scale's with skill, genes, hediffs and etc
  • ranged AP scales the same as damage by quality factor
  • factors shown in description

Reasoning

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (gene and melee skill)

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9053918826.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label May 12, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9118347668.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9150009287.zip

@MaxDorob MaxDorob marked this pull request as ready for review May 19, 2024 19:31
@MaxDorob MaxDorob requested review from a team as code owners May 19, 2024 19:31
SamaelGray
SamaelGray approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@SamaelGray SamaelGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended.

@MaxDorob MaxDorob changed the title Melee AP changes AP factors May 25, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9238450198.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9242087695.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9246602523.zip

N7Huntsman
N7Huntsman reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set up xml StatDefs for the 'Skill' and 'Other' factors similar to the one we have for RangedWeapon_DamageMultiplier so we can expose them for easier balance tweaking in the future? Or are the values too abstract for that to be practical?

@SamaelGray
Copy link
Contributor

It's 25% max for skill from level 0 to 20 and other category of factors is by the same amount that the damage/AP is increased to the power of 0.75, don't see a need for xml exposing. The AP increase for ranged weapons is the same exact percentage as damage increase based on quality.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9360425720.zip

@N7Huntsman N7Huntsman merged commit 1c00423 into Development Jun 11, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the Melee_AP_Changes branch June 11, 2024 08:30
masakitenchi added a commit to masakitenchi/Hardcore-SK that referenced this pull request Jun 15, 2024
@masakitenchi
Merge upstream CE
80b4596 
up until
CombatExtended-Continued/CombatExtended@1c00423

Highlight PR(s):
CombatExtended-Continued/CombatExtended#3134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamaelGray SamaelGray SamaelGray approved these changes

@N7Huntsman N7Huntsman N7Huntsman approved these changes

@Thorbane Thorbane Thorbane approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxDorob @SamaelGray @Thorbane @N7Huntsman