Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render changes #3186

Merged
merged 14 commits into from
Jun 23, 2024
Merged

Render changes #3186

merged 14 commits into from
Jun 23, 2024

Conversation

MaxDorob
Copy link
Contributor

@MaxDorob MaxDorob commented Jun 11, 2024 •
edited
Loading

Additions

Describe new functionality added by your code, e.g.

  • Custom PawnRenderNode_Apparel (technically the same as original)
  • PawnRenderWorker_Drafted - Draws node when pawn drafted only (or due to job/mind state)

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Uncommented and changed visual recoil transpiler (transpiled method were made static, so changed args number only)
  • Changed draw of shields (now melee shield only) to PawnRenderNode
  • Removed obsolete commented code (useless since 1.5)
  • Increased version or Rimworld reference assembly

image
image

Reasoning

Why did you choose to implement things this way, e.g.

  • No visual recoil
  • Some apparel renders incorrect

Alternatives

Describe alternative implementations you have considered, e.g.

  • Who cares about visual part?

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9470099148.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 11, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9470193733.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9470420796.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9538559163.zip

@MaxDorob MaxDorob marked this pull request as ready for review June 16, 2024 22:18
@MaxDorob MaxDorob requested review from a team as code owners June 16, 2024 22:18
SamaelGray
SamaelGray approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@SamaelGray SamaelGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weapon recoil and GunDrawExtension are working again as intended.

N7Huntsman
N7Huntsman previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing.

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9567196710.zip

Airomeda
Airomeda previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine on my playtesting 👍

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9622133076.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9622346211.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9623008077.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9623008076.zip

@N7Huntsman N7Huntsman merged commit 17553ee into Development Jun 23, 2024
4 checks passed
@N7Huntsman N7Huntsman deleted the RenderChanges branch June 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamaelGray SamaelGray SamaelGray approved these changes

@N7Huntsman N7Huntsman N7Huntsman approved these changes

@perkinslr perkinslr perkinslr approved these changes

@Airomeda Airomeda Airomeda left review comments

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MaxDorob @perkinslr @N7Huntsman @SamaelGray @Airomeda