Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verb translation keys #3363

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Add verb translation keys #3363

merged 2 commits into from
Aug 22, 2024

Conversation

N7Huntsman
Copy link
Contributor

Additions

  • Keys for a few messages that can appear in the targeting/aiming info box.

Changes

  • Swap a few strings in English out for translation keys.

References

Reasoning

  • This text can appear to the player, so there's no reason not to key it.

Alternatives

  • Suffer (in languages other than English).

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners August 22, 2024 01:48
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10500405396.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Aug 22, 2024
@N7Huntsman N7Huntsman mentioned this pull request Aug 22, 2024
Closed
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10500421824.zip

@N7Huntsman N7Huntsman merged commit 7dfc01f into Development Aug 22, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the TranslationKeys branch August 22, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thorbane Thorbane Thorbane approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Localization Key is missing
2 participants
@N7Huntsman @Thorbane