generic projectile label override #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10630975139.zip |
github-actions
bot
added
the
Download in Comments
N7Huntsman
reviewed
Sep 4, 2024
Defs/Ammo/Pistols/45ACP.xml
Outdated
|
|
||
| <!-- ================== Projectiles ================== --> | ||
|
|
||
| <ThingDef Class="CombatExtended.AmmoDef" Name="Base45ACPBullet" ParentName="BaseBulletCE" Abstract="true"> |
There was a problem hiding this comment.
Why add Class="CombatExtended.AmmoDef" here, seeing as these are projectiles, not ammo items?
There was a problem hiding this comment.
label override is a field in ammodef.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10734233670.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-10734450134.zip |
MaxDorob
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
GenericLabelOverride field in CombatExtended.AmmoDef. Ammo generalizer will use it for projectile name if present.
Changes
Translation key for " bullet " in Ammo generalizer, since I stumbled across it.
NoTranslate annotation in AmmoDef's oldDescription, it has been annoying me forever and I happened to come across it.
Reasoning
Intended for edge cases.
Alternatives
Revolver shotgun SMG.
Testing
Check tests you have performed: