Only consume ammo for shots that were actually fired

[mszabo-wikia]

Changes

• Centralize ammo management for verbs within Verb_ShootCE
• Split ammo count check / selection and ammo consumption into separate methods
• Consume ammo in OnCastSuccessful rather than before attempting the shot

References

• Closes [Bug]: Some automatic weapons seem to 'ghost fire', consuming the ammo but not firing anything #3500

Reasoning

• Verb_LaunchProjectileCE doesn't need to know about CompAmmo, only Verb_ShootCE and derivatives do. The current system leads to reload / ammo management logic being copypasted across verb classes, which is error-prone.
• We currently check for and reduce ammo count before checking if a shot can actually be fired. For burst weapons with interruptibleBurst = true, this can cause extra ammo to be consumed without a corresponding shot being made.

Testing

• Compiles without warnings
• Game runs without errors
• Playtested a colony - spawned in a KPV with APHE and targeted a wooden wall directly next to it. With this change, this consumes 2 bullets instead of 3. Also tested automatic reloading and out of ammo behavior with a gun-wielding colonist.

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12000520980.zip

[mszabo-wikia]

Note: While testing this, I found that the preexisting logic doesn't consistently enforce ammoConsumedPerShotCount, meaning it is possible to fire a weapon with ammoConsumedPerShotCount = X with less than X bullets in the mag. However, fixing that would be a larger change, since the assumption that a nonzero bullet count in the mag / inventory allows a weapon to be fired is widespread, so I opted against trying to fix it here.

[N7Huntsman]

Fixes the issue in my testing.