-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerApp evn var collections #922
Conversation
Added a fix for #921 |
@@ -34,7 +34,12 @@ type ContainerAppConfig = | |||
ImageRegistryCredentials : ImageRegistryAuthentication list | |||
Containers : ContainerConfig list | |||
Dependencies : Set<ResourceId> } | |||
|
|||
member this.ResourceId = containerApps.resourceId this.Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think line 51 is correct actually, wondering if I should fix that too. I'm thinking it should be managedEnvironments.resourceId
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right, it's the managed environment, so this is a lurking bug.
@forki what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new operations look good, thank you for adding those and the tests to use them.
Are the ACR changes just a temporary workaround?
@@ -34,7 +34,12 @@ type ContainerAppConfig = | |||
ImageRegistryCredentials : ImageRegistryAuthentication list | |||
Containers : ContainerConfig list | |||
Dependencies : Set<ResourceId> } | |||
|
|||
member this.ResourceId = containerApps.resourceId this.Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right, it's the managed environment, so this is a lurking bug.
username = ArmExpression.create($"listCredentials({resourceId.ArmExpression.Value}, '2019-05-01').username").Eval() | ||
passwordSecretRef = ArmExpression.create($"listCredentials({resourceId.ArmExpression.Value}, '2019-05-01').username").Eval() |} | ||
passwordSecretRef = usernameSecretName resourceId |} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it we just need this for now until this bug is fixed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, yes. Although the string concatenation approach should just work, once the underlying ARM provider is fixed I would prefer to revert to the original expression-based approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, and given we do t have to change the DSL, this will just keep working when they fix the bug. LGTM.
Thanks for the contribution, this is released in 1.7.1 and available on nuget. |
The changes in this PR are as follows:
containerApp
Why is this useful? In the absence of broad support for
_.For
in this library this makes iterators possible and brings it to parity with some other CEs.I have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure: