Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gcp wif in preproduction env #427

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

RMcVelia
Copy link
Contributor

Context

Enable GCP WIF for the preproduction environment

Changes proposed in this pull request

Add required config
Override gcp_dataset to point to existing preprod dataset

Guidance to review

make preproduction terraform-plan

Link to Trello card

https://trello.com/c/zBJkGucG/2142-ccbl-migrate-to-gcp-wif

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@vipin-dfe
Copy link

lgtm.

@RMcVelia RMcVelia force-pushed the 2142-ccbl-migrate-to-gcp-wif-preprod branch from 03c8bc5 to 8121f4f Compare November 29, 2024 11:09
@RMcVelia
Copy link
Contributor Author

CCBL: migrate to GCP WIF

@RMcVelia RMcVelia merged commit c7fa38a into main Nov 29, 2024
12 checks passed
@RMcVelia RMcVelia deleted the 2142-ccbl-migrate-to-gcp-wif-preprod branch November 29, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants