tao_idl Improvements #1357
tao_idl Improvements #1357
Conversation
Remove support for these environment variables because they have been marked as deprecated for at least 20 years at this point.
Use conventional HTML, non breaking dashs, remove some outdated information.
Make it easier to read and edit by replacing tabs with spaces.
Fixes an issue that came up in OpenDDS/OpenDDS#2161. To make behavior of `#include ".."` consistent with C and C++, change how `tao_idl` calls the C preprocessor by default in most cases from making a copy of the IDL file to using the IDL file directly.
|
Very likely some old preprocessors had issues when passing them a IDL file directly due to the idl extension, some required it to be c/cpp |
This is a backport of the same commit in DOCGroup#1357, but with copy preprocessor input method being the default. Fixes an issue that came up in OpenDDS/OpenDDS#2161. To make behavior of `#include ".."` consistent with C and C++, change how `tao_idl` calls the C preprocessor by default in most cases from making a copy of the IDL file to using the IDL file directly.
| else | ||
| { | ||
| i++; | ||
| if (!ACE_OS::strcmp (av[i], "guess")) |
There was a problem hiding this comment.
Can use std::strcmp now without problems
| ACE_DEBUG ((LM_DEBUG, "%C: guessing preprocessor input method using name: %C\n", | ||
| idl_global->prog_name (), cpp_name)); | ||
| } | ||
| if (ACE_OS::strstr (cpp_name, "g++")) // g++ or clang++ |
| // method. Warn about it anyway, because it shouldn't happen. | ||
| idl_global->preprocessor_input_ = IDL_GlobalData::PreprocessorInputCopy; | ||
| if (!(idl_global->compile_flags () & IDL_CF_NOWARNINGS)) | ||
| ACE_ERROR ((LM_WARNING, |
| // Decide how files will be passed to the preprocessor | ||
| if (idl_global->preprocessor_input_ == IDL_GlobalData::PreprocessorInputGuess) | ||
| { | ||
| const char * const cpp_name = tolower (our_basename (FE_get_cpp_loc_from_env ())); |
There was a problem hiding this comment.
What about setting the default through the various config-* files, there we also set the default preprocessor to be used? We have there ACE_CC_PREPROCESSOR and ACE_CC_PREPROCESSOR_ARGS already. We could add a define there to set the preprocessor input handling type. That looks to be easier than trying to determine it here based on the name of the pre processor separately here. When we set the default through a define the user can always overrule it with a different setting on the commandline
|
Found recently that bcc32c/bcc64 (the Embarcadero clang based compilers) can't preprocess a file with a IDL extension, we need a copy with cpp extension with those compilers. |
I know it's been a long time, but are you sure it can't do it like normal clang using |
|
bcc64/bcc64x seems to support |
|
So I decided to download it to see what it's doing (this was annoying because they wanted an account, but didn't even give me the 64-bit compilers...). |
|
To give the current context, I'm trying to see what it would take to get this PR merged because I occasionally see This is probably a problem with GitHubs VMs, but I wanted to do this anyways. I also noticed it just failed in a job from the merge commit: However because this is in this PR, then something's wrong with my current code and it shouldn't have done this. So the guessing probably isn't working on Windows. As Johnny suggested originally I think I'm going to have it work use macros, at least for the defaults, but I need to think about the specifics. |
|
Would be nice when we don't need that copy step anymore with most compilers, will speed up the builds a little bit, especially on Windows |
__TAO_IDL_IDL_VERSION.__TAO_IDLIDL preprocessor macro.CPP_LOCATIONandTAO_IDL_DEFAULT_CPP_FLAGSenvironment variables.idl2jni, which is atao_idl-derived compiler, can't properly handle relative includes becausetao_idlmakes a temporary copy that is passed to the preprocessor. Fixed this by making it preferred to pass the IDL file to the preprocessor directly.