Upgrade direct Python dependencies (#6511) #6649

achave11-ucsc · 2024-10-23T15:37:54Z

Connected issues: #6511

Checklist

Author

PR is a draft
Target branch is develop
Name of PR branch matches issues/<GitHub handle of author>/<issue#>-<slug>
On ZenHub, PR is connected to all issues it (partially) resolves
PR description links to connected issues
PR title matches¹ that of a connected issue _{or comment in PR explains why they're different}
PR title references all connected issues
For each connected issue, there is at least one commit whose title references that issue

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all connected issues}
This PR partially resolves each of the connected issues _{or does not have the partial label}

Author (chains)

This PR is blocked by previous PR in the chain _{or is not chained to another PR}
The blocking PR is labeled base _{or this PR is not chained to another PR}
This PR is labeled chained _{or is not chained to another PR}

Author (reindex, API changes)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}
This PR and its connected issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any connected issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues connected to this PR}

Author (before every review)

Rebased PR branch on develop, squashed old fixups
Ran make requirements_update _{or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}

Peer reviewer (after approval)

PR is not a draft
Ticket is in Review requested column
PR is awaiting requested review from system administrator
PR is assigned to only the system administrator

System administrator (after approval)

Actually approved the PR
Labeled connected issues as demo or no demo
Commented on connected issues about demo expectations _{or all connected issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Moved connected issues to Approved column
PR is assigned to only the operator

Operator (before pushing merge the commit)

System administrator

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (before pushing merge the commit)

Operator (chain shortening)

Changed the target branch of the blocked PR to develop _{or this PR is not labeled base}
Removed the chained label from the blocked PR _{or this PR is not labeled base}
Removed the blocking relationship from the blocked PR _{or this PR is not labeled base}
Removed the base label from this PR _{or this PR is not labeled base}

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

coveralls · 2024-10-23T18:12:48Z

coverage: 85.58% (-0.007%) from 85.587%
when pulling a87b063 on issues/achave11-ucsc/6511-bump-python-pkgs
into 93637ff on develop.

codecov · 2024-10-23T18:14:49Z

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.56%. Comparing base (93637ff) to head (a87b063).

Files with missing lines	Patch %	Lines
test/integration_test.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6649      +/-   ##
===========================================
- Coverage    85.57%   85.56%   -0.01%     
===========================================
  Files          154      154              
  Lines        20915    20904      -11     
===========================================
- Hits         17897    17886      -11     
  Misses        3018     3018

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

dsotirho-ucsc

Even though it is called python-requests in the User-Agent header, it is just the requests package, so I think it should be requests in the commit message:

< [R] Bumped python-requests to 2.32.3 (#6511)
> [R] Bumped requests to 2.32.3 (#6511)

dsotirho-ucsc · 2024-10-28T22:26:36Z

test/azul_test_case.py

@@ -147,6 +147,15 @@ class RE(str):
                    'The \'body\' parameter is deprecated for the \'.*\' API '
                    'and will be removed in .*. Instead use .*'
                ),
+                'validate_spec shortcut is deprecated. Use validate instead.',


This should have a FIXME comment linking to a new issue.

dsotirho-ucsc

To match other commit titles:

< [R] Bumped requests to 2.32.3 (#6511)
> [R] Bump requests to 2.32.3 (#6511)

dsotirho-ucsc · 2024-11-07T18:40:12Z

test/azul_test_case.py

+                    'Automatically retrieving remote references can be a security vulnerability and'
+                    ' is discouraged by the JSON Schema specifications. Relying on this behavior is'
+                    ' deprecated and will shortly become an error. If you are sure you want to '
+                    'remotely retrieve your reference and that it is safe to do so, you can find '
+                    'instructions for doing so via referencing.Registry in the referencing '
+                    'documentation (https://referencing.readthedocs.org).'


Inconsistent line continuation (some lines start with a space, other lines end with a space). In this situation Hannes prefers lines do not start with a space (so place the space at the end of the previous line).

dsotirho-ucsc

The two

[R] Ran make `requirements_update`

commits can be combined so there is only one as the final commit in this PR, and there is a typo in the commit title (the backquote should start before make)

[R] Ran `make requirements_update`

dsotirho-ucsc

Approved.

hannes-ucsc · 2024-11-14T19:09:35Z

requirements.txt

+# Updating the following package beyond 3.13.x > breaks test & production code
+google-cloud-bigquery==3.13.0


Can't have comment lines like this. Each line needs to be a dependency. If there is a comment, it needs to be at the end of a dependency line. Please create a ticket and

Suggested change

# Updating the following package beyond 3.13.x > breaks test & production code

google-cloud-bigquery==3.13.0

google-cloud-bigquery==3.13.0 # Can't go higher, due to <insert ticket reference here>

The ticket should have a reproduction indicating what breaks if we were to go higher. The title of the commit should refer to #6511 and the new ticket.

Understood. But just to clarify, I was following the directive as prescribed (last sentence).

test/azul_test_case.py

achave11-ucsc · 2024-11-15T19:09:35Z

requirements.txt

+# Updating the following package beyond 3.13.x > breaks test & production code
+google-cloud-bigquery==3.13.0


Understood. But just to clarify, I was following the directive as prescribed (last sentence).

…6511, #6709)

hannes-ucsc

Could you please add a checklist item to upgrade issues that reminds us to upgrade direct Python dependencies, and a operator manual section that describes the operating procedure for that? It could make use of the PyCharm intention that I mentioned on the issue. The procedure should also state that we only do non-problematic updates, and that we would add a FIXME for those that require more work.

I bumped the estimate by 1 to accommodate this extension of scope.

github-actions bot added the orange [process] Done by the Azul team label Oct 23, 2024

achave11-ucsc added the reqs [process] PR includes commit requiring ``make requirements`` label Oct 23, 2024

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch 4 times, most recently from 6892a70 to 2dd0f26 Compare October 23, 2024 17:53

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch 2 times, most recently from 8b6db7f to 686c426 Compare October 28, 2024 18:28

achave11-ucsc requested a review from dsotirho-ucsc October 28, 2024 21:15

achave11-ucsc assigned dsotirho-ucsc Oct 28, 2024

dsotirho-ucsc requested changes Oct 28, 2024

View reviewed changes

dsotirho-ucsc removed their assignment Oct 28, 2024

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch from 5833737 to cdecf66 Compare October 29, 2024 19:34

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch from cdecf66 to 48728b4 Compare November 6, 2024 19:17

achave11-ucsc requested a review from dsotirho-ucsc November 6, 2024 21:34

achave11-ucsc assigned dsotirho-ucsc Nov 6, 2024

dsotirho-ucsc requested changes Nov 7, 2024

View reviewed changes

dsotirho-ucsc removed their assignment Nov 7, 2024

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch 2 times, most recently from 5d209cd to 61202e0 Compare November 13, 2024 00:03

achave11-ucsc assigned dsotirho-ucsc Nov 13, 2024

achave11-ucsc requested a review from dsotirho-ucsc November 13, 2024 00:58

dsotirho-ucsc requested changes Nov 13, 2024

View reviewed changes

dsotirho-ucsc removed their assignment Nov 13, 2024

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch 2 times, most recently from af99f7e to ba8b955 Compare November 13, 2024 17:53

achave11-ucsc requested a review from dsotirho-ucsc November 13, 2024 18:32

achave11-ucsc assigned dsotirho-ucsc Nov 13, 2024

dsotirho-ucsc previously approved these changes Nov 13, 2024

View reviewed changes

dsotirho-ucsc marked this pull request as ready for review November 13, 2024 21:58

dsotirho-ucsc requested a review from hannes-ucsc as a code owner November 13, 2024 21:58

dsotirho-ucsc assigned hannes-ucsc and unassigned dsotirho-ucsc Nov 13, 2024

hannes-ucsc requested changes Nov 14, 2024

View reviewed changes

hannes-ucsc removed their assignment Nov 14, 2024

achave11-ucsc dismissed dsotirho-ucsc’s stale review via 51c3162 November 15, 2024 18:35

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch from ba8b955 to 51c3162 Compare November 15, 2024 18:35

achave11-ucsc commented Nov 15, 2024

View reviewed changes

achave11-ucsc requested a review from hannes-ucsc November 15, 2024 21:06

achave11-ucsc assigned hannes-ucsc and unassigned hannes-ucsc Nov 15, 2024

achave11-ucsc added 8 commits November 21, 2024 07:56

Fix ordering in requirement files

88cbfd8

[R] Upgrade direct Python dependencies & cap google-cloud-bigquery (#…

201e824

…6511, #6709)

[R] Bump requests to 2.32.3 (#6511)

b3dfffc

[R] Bump awscli, boto* and moto packages to more recent versions (#6511)

e759c14

[R] Bump openapi-spec-validator to 0.7.1 (#6511)

6064846

Add FIXME (#6666)

e622b28

[R] Bump flake8 to 7.1.1 (#6511)

85cbbcf

[R] Ran make requirements_update

a87b063

achave11-ucsc force-pushed the issues/achave11-ucsc/6511-bump-python-pkgs branch from 51c3162 to a87b063 Compare November 21, 2024 16:04

achave11-ucsc assigned hannes-ucsc Nov 21, 2024

hannes-ucsc requested changes Nov 22, 2024

View reviewed changes

hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Nov 22, 2024

hannes-ucsc removed their assignment Nov 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade direct Python dependencies (#6511) #6649

Upgrade direct Python dependencies (#6511) #6649

achave11-ucsc commented Oct 23, 2024 •

edited by dsotirho-ucsc

Loading

coveralls commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading

dsotirho-ucsc left a comment

dsotirho-ucsc Oct 28, 2024

dsotirho-ucsc left a comment

dsotirho-ucsc Nov 7, 2024 •

edited

Loading

dsotirho-ucsc left a comment

dsotirho-ucsc left a comment

hannes-ucsc Nov 14, 2024

achave11-ucsc Nov 15, 2024

achave11-ucsc Nov 15, 2024

hannes-ucsc left a comment

		# Updating the following package beyond 3.13.x > breaks test & production code
		google-cloud-bigquery==3.13.0

	# Updating the following package beyond 3.13.x > breaks test & production code
	google-cloud-bigquery==3.13.0
	google-cloud-bigquery==3.13.0 # Can't go higher, due to <insert ticket reference here>

Upgrade direct Python dependencies (#6511) #6649

Are you sure you want to change the base?

Upgrade direct Python dependencies (#6511) #6649

Conversation

achave11-ucsc commented Oct 23, 2024 • edited by dsotirho-ucsc Loading

Checklist

Author

Author (partiality)

Author (chains)

Author (reindex, API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator (before pushing merge the commit)

System administrator

Operator (before pushing merge the commit)

Operator (chain shortening)

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Shorthand for review comments

coveralls commented Oct 23, 2024 • edited Loading

codecov bot commented Oct 23, 2024 • edited Loading

Codecov Report

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

dsotirho-ucsc Oct 28, 2024

Choose a reason for hiding this comment

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

dsotirho-ucsc Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

hannes-ucsc Nov 14, 2024

Choose a reason for hiding this comment

achave11-ucsc Nov 15, 2024

Choose a reason for hiding this comment

achave11-ucsc Nov 15, 2024

Choose a reason for hiding this comment

hannes-ucsc left a comment

Choose a reason for hiding this comment

achave11-ucsc commented Oct 23, 2024 •

edited by dsotirho-ucsc

Loading

coveralls commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading

dsotirho-ucsc Nov 7, 2024 •

edited

Loading