-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCJ-286] Add bulk User operations to dropdown on SO Console #2563
[DCJ-286] Add bulk User operations to dropdown on SO Console #2563
Conversation
…DAAs-to-user-s-LC
…DAAs-to-user-s-LC
…User-Operation-Dropdown
…have left dropdown
If you change the base of this PR to be #2562, then we'll only see diff between these two instead of all of the changes between this PR and develop: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interim review, I'll take another look when we're closer with the base PR. Works as expected! See comments inline.
src/pages/signing_official_console/SigningOfficialResearchers2.jsx
Outdated
Show resolved
Hide resolved
…-LC' into an-DCJ-286-UI-Update-SO-Console-Add-Bulk-User-Operation-Dropdown
I'm seeing a new error on this PR that I don't see on dev. Not sure if it is unrelated to changes here yet:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! See optional feedback inline.
I observed this error in dev yesterday and will file a seperate ticket to fix it @rushtong
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, otherwise looks good:
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-286
Summary
Adds the dropdown in the Name column allowing a Signing Official to apply all DAAs or remove all DAAs to and from one user at a time.
Note: this PR depends on this corresponding PR.
Have you read Terra's Contributing Guide lately? If not, do that first.