Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-286] Add bulk User operations to dropdown on SO Console #2563

Conversation

aarohinadkarni
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-286

Summary

Adds the dropdown in the Name column allowing a Signing Official to apply all DAAs or remove all DAAs to and from one user at a time.

Note: this PR depends on this corresponding PR.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@aarohinadkarni aarohinadkarni requested a review from a team as a code owner May 2, 2024 20:44
@aarohinadkarni aarohinadkarni requested review from rushtong and okotsopoulos and removed request for a team May 2, 2024 20:44
@rushtong
Copy link
Contributor

rushtong commented May 3, 2024

If you change the base of this PR to be #2562, then we'll only see diff between these two instead of all of the changes between this PR and develop:

Screenshot 2024-05-03 at 8 28 45 AM

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interim review, I'll take another look when we're closer with the base PR. Works as expected! See comments inline.

src/components/SimpleTable.jsx Outdated Show resolved Hide resolved
Base automatically changed from an-DUOS-2916-UI-Update-SO-Console-Manage-DAAs-to-user-s-LC to develop May 7, 2024 13:45
@rushtong
Copy link
Contributor

rushtong commented May 8, 2024

I'm seeing a new error on this PR that I don't see on dev. Not sure if it is unrelated to changes here yet:

Warning: A props object containing a "key" prop is being spread into JSX:
  let props = {key: someKey, onClick: ..., onMouseEnter: ..., onMouseLeave: ..., style: ..., data-tip: ..., id: ..., children: ...};
  <span {...props} />
React keys must be passed directly to JSX without using spread:
  let props = {onClick: ..., onMouseEnter: ..., onMouseLeave: ..., style: ..., data-tip: ..., id: ..., children: ...};
  <span key={someKey} {...props} />
    at TableIconButton (https://local.broadinstitute.org:3000/static/js/bundle.js:9519:51)
    at div
    at Actions (https://local.broadinstitute.org:3000/static/js/bundle.js:12907:5)
    at div
    at div
    at DataRows (https://local.broadinstitute.org:3000/static/js/bundle.js:8773:5)
    at div
    at div
    at SimpleTable (https://local.broadinstitute.org:3000/static/js/bundle.js:8866:5)
    at DarCollectionTable (https://local.broadinstitute.org:3000/static/js/bundle.js:13660:101)
    ...

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! See optional feedback inline.

src/pages/signing_official_console/DAACell.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/DAACell.jsx Outdated Show resolved Hide resolved
@PintoGideon
Copy link
Contributor

PintoGideon commented May 8, 2024

I observed this error in dev yesterday and will file a seperate ticket to fix it @rushtong

> Warning: A props object containing a "key" prop is being spread into JSX:
>   let props = {key: someKey, onClick: ..., onMouseEnter: ..., onMouseLeave: ..., style: ..., data-tip: ..., id: ..., children: ...};
>   <span {...props} />
> React keys must be passed directly to JSX without using spread:
>   let props = {onClick: ..., onMouseEnter: ..., onMouseLeave: ..., style: ..., data-tip: ..., id: ..., children: ...};
>   <span key={someKey} {...props} />
>     at TableIconButton (https://local.broadinstitute.org:3000/static/js/bundle.js:9519:51)
>     at div
>     at Actions (https://local.broadinstitute.org:3000/static/js/bundle.js:12907:5)
>     at div
>     at div
>     at DataRows (https://local.broadinstitute.org:3000/static/js/bundle.js:8773:5)
>     at div
>     at div
>     at SimpleTable (https://local.broadinstitute.org:3000/static/js/bundle.js:8866:5)
>     at DarCollectionTable (https://local.broadinstitute.org:3000/static/js/bundle.js:13660:101)

fboulnois

This comment was marked as outdated.

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, otherwise looks good:

src/components/SimpleTable.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/DAACell.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/DAACell.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/DAACell.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/ManageDaasDropdown.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/ManageDaasDropdown.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/ManageDaasDropdown.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/ManageUsersDropdown.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/ManageUsersDropdown.jsx Outdated Show resolved Hide resolved
src/pages/signing_official_console/ManageUsersDropdown.jsx Outdated Show resolved Hide resolved
@aarohinadkarni aarohinadkarni merged commit e4f2ba0 into develop May 10, 2024
9 checks passed
@aarohinadkarni aarohinadkarni deleted the an-DCJ-286-UI-Update-SO-Console-Add-Bulk-User-Operation-Dropdown branch May 10, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants