[DT-1055] Pin version of NodeJS to latest LTS

[fboulnois]

Addresses

https://broadworkbench.atlassian.net/browse/DT-1055

Summary

This will prevent developers from accidentally installing incompatible version of NodeJS for the UI.

---

Have you read Terra's Contributing Guide lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[rushtong]

👍🏽

[rushtong]

👍🏽

[pshapiro4broad]

This looks OK, although it's a shame we need to have the version both in package.json and in all the GitHub workflows.

Also, can you also update DEVNOTES.md to reflect this change?

[pshapiro4broad]

Would it be wrong to use an exact match here too?

[fboulnois]

I was thinking we could do that, but any future developer would get stuck with newer versions of NodeJS (for example patch or minor). Perhaps that's a reasonable trade-off to make. Another thing to think about is that we probably do want to test newer versions, so it might be too much friction to lock it down completely.

[rushtong]

This looks OK, although it's a shame we need to have the version both in package.json and in all the GitHub workflows.

It's also in Dockerfile ... I'd love to see a better way to specify this globally.

[fboulnois]

This looks OK, although it's a shame we need to have the version both in package.json and in all the GitHub workflows.

It's also in Dockerfile ... I'd love to see a better way to specify this globally.

I am hoping Dependabot is smart enough to update it everywhere. If not, we can use a slightly different approach and extract the version like we do when installing Homebrew.