Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DT-1055] Pin version of NodeJS to latest LTS #2734

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[DT-1055] Pin version of NodeJS to latest LTS #2734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b461b82
feat: pin version of nodejs to latest lts
fboulnois Nov 21, 2024
3fa117f
chore: install correct version of nodejs in runner
fboulnois Nov 21, 2024
19aa3fa
docs: update node install and version
fboulnois Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/audit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '22.11.0'
- name: install dependencies
run: npm ci
- name: npm audit
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/component-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ jobs:
run: echo "${{ github.actor }}"
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '22.11.0'
- name: NPM Install
run: npm ci
- name : Cypress run component tests
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ jobs:
run: echo "${{ github.actor }}"
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '22.11.0'
- name: NPM Install
run: npm ci
- name: Copy Configs
Expand Down
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
6 changes: 3 additions & 3 deletions DEVNOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Local Development

1. We use [node@22.6.0](https://github.com/nvm-sh/nvm#installing-and-updating):
1. We use [node@22.11.0](https://docs.volta.sh/guide/understanding):

```
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash
nvm install 22.6.0
volta install 22.11.0
```

2. Install deps:

```
Expand Down
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,8 @@
"not dead",
"not ie <= 11",
"not op_mini all"
]
],
"engines": {
"node": ">=22.11.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be wrong to use an exact match here too?

Copy link
Contributor Author

@fboulnois fboulnois Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we could do that, but any future developer would get stuck with newer versions of NodeJS (for example patch or minor). Perhaps that's a reasonable trade-off to make. Another thing to think about is that we probably do want to test newer versions, so it might be too much friction to lock it down completely.

}
}
Loading