Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate guides/tutorial/part-2/ember-data.md #242

Merged
merged 1 commit into from
May 6, 2024

Conversation

BlueCutOfficial
Copy link
Member

Closes #151

@BlueCutOfficial BlueCutOfficial self-assigned this Feb 23, 2024
@BlueCutOfficial BlueCutOfficial added the Guides FR trad File from the Ember Guides to translate in French label Feb 23, 2024
Copy link
Member

@MrChocolatine MrChocolatine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions adapteur => adaptateur represent 80% of the comments.


Not directly related to the PR/translation itself: what's was your feeling/experience when translating this file now #233 and #241 have been merged? Any feedback?

guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
guides/tutorial/part-2/ember-data.md Outdated Show resolved Hide resolved
@BlueCutOfficial BlueCutOfficial force-pushed the translate-guides-tutorial-part-2-ember-data branch 2 times, most recently from 8a9f19c to ac01c88 Compare March 4, 2024 08:44
@BlueCutOfficial
Copy link
Member Author

I haven't really used the .local.dic sorting yet because it wasn't an effort for me to put the new exceptions in the right place, but I have no doubt it's super useful in general and will prevent a lot of careless mistakes in the long run.
The pre-commit hook is going to be life-saving. One thing I noticed is I have the following message:

.remarkignore was not in your staged files, so we have added it for you.

...when I amend my commit, but aside from the message itself it doesn't have any unwanted effect.

@MrChocolatine MrChocolatine force-pushed the translate-guides-tutorial-part-2-ember-data branch from ac01c88 to bdc0267 Compare April 28, 2024 12:17
@MrChocolatine MrChocolatine force-pushed the translate-guides-tutorial-part-2-ember-data branch from bdc0267 to 6ae9878 Compare April 28, 2024 12:18
@MrChocolatine MrChocolatine force-pushed the translate-guides-tutorial-part-2-ember-data branch from 6ae9878 to d4e12db Compare May 6, 2024 13:52
@MrChocolatine
Copy link
Member

@BlueCutOfficial , let's move forward.

Just to let you know I have merged these commits into your first one

image

@MrChocolatine MrChocolatine merged commit 8097cda into master May 6, 2024
2 checks passed
@MrChocolatine MrChocolatine deleted the translate-guides-tutorial-part-2-ember-data branch May 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guides FR trad File from the Ember Guides to translate in French
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate /tutorial/part-2/ember-data.md, Ember 4.7
2 participants