-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account history component style and code revamp #128
feat: account history component style and code revamp #128
Conversation
✅ Deploy Preview for chipper-sunburst-578cfe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvgeniiaVak i have fixed it, you can check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Border radii should probably be 0 for both the count indicator and the cancel button on hover to look consistent with the rest of the styling, which is quite rectangular. Strange that they are not absent by default on the button, we have it in the tailwind config for all the buttons.
The cancel
button (when without hover) looks a little bit out of place - shifted to the right, 🤔 maybe moving the cancel button a little bit (e.g. use negative padding? what can go wrong? 😆 ). Or maybe remove the on hover at all, or only underline on hover? I vote for only underlining, with no bg changes.
Other differences from figma:
- all headers are uppercase
cancel
is red- the selected tab has accent color
I committed in this branch also, someone else needs to review my latest commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nguvictor reviewed (thanks), so approving this PR.
fixes #120
i have opened this PR, for now it is not responsive for tab and mobile. will be working on it's responsiveness in the coming days