Charts enhancement #145
Merged
Charts enhancement #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated source files to upstream main
…" to use current candle
- resized the chart - changed color for chart timescale and pricescale to be more visible
…/dexter into redux-charts-enhancement
✅ Deploy Preview for chipper-sunburst-578cfe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
EvgeniiaVak
requested changes
Oct 3, 2023
src/app/components/PriceChart.tsx
Outdated
| }, | ||
| //MODIFY THEME COLOR HERE | ||
| grid: { | ||
| vertLines: { color: "#292C34" }, //neutral |
There was a problem hiding this comment.
@nguvictor we don't use the neutral mostly, maybe base-200? also please review #128 I'm updating colors there to reflect figma more.
Maybe use js import (import the js object from tailwind.config.js instead of hard-copying?
There was a problem hiding this comment.
Base-200 wasn't visible even after adjusting to #191B1D found in #128
primary-content was way too strong
secondary-content seems about right
EvgeniiaVak
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Classes and tweaking padding, wrapped numbers in displayAmount.