-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Charts enhancement #145
Merged
EvgeniiaVak
merged 30 commits into
DeXter-on-Radix:main
from
nguvictor:charts-enhancement
Oct 4, 2023
Merged
Charts enhancement #145
Changes from 27 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
08853c6
chart styling 1st
maelsar 74de128
TF selector buttons
maelsar 53ebf23
Working Chart - before refactoring
maelsar f7939a6
update2 before refactor
maelsar aa41128
Merge branch 'DeXter-on-Radix:main' into redux-charts-enhancement
maelsar a068194
Synced with upstream/main
maelsar 10a0fae
Refactored crosshair data (for legend) to use redux store
maelsar 9c338f8
Moved helper functions to utils. Moved Crosshair data fetching to slice
maelsar ea0f07b
fixed eslint warning
maelsar 38ea250
removed pairname from selector bar
maelsar d741fb1
price selector and cursor prices (legend) applied to charts component
maelsar ba0a17e
added color formatting to legend values and refactored "Change" logic
maelsar c8f87f0
Updated volumeSeries type to NOT "any" -- Updated Legend Data "Change…
maelsar 2a19b52
refactored volume bars logic and updated color change
maelsar 95de744
added async thunk to update legend values to latest candle values
maelsar 68ead59
Removed unused variables and cleaned up comments
maelsar ddae4d8
Merge branch 'DeXter-on-Radix:main' into redux-charts-enhancement
maelsar 8af4225
Merge remote-tracking branch 'upstream/main' into redux-charts-enhanc…
maelsar cfca325
Merge branch 'redux-charts-enhancement' of https://github.com/maelsar…
maelsar 3469da7
Updated to correct after sync.
maelsar b141a31
Merge branch 'DeXter-on-Radix:main' into redux-charts-enhancement
maelsar b637a7b
Merge branch 'DeXter-on-Radix:main' into redux-charts-enhancement
maelsar 2045cef
Removed async thunk
maelsar 0b4077c
Removed the gap between the legend bar and chart
maelsar 8a8160e
Merge branch 'DeXter-on-Radix:main' into redux-charts-enhancement
maelsar 590580d
color and some padding changes
49a982b
cleaned up import
ccda908
color adjustments
ad6e637
fixed prettier
428e680
Merge branch 'main' into charts-enhancement
nguvictor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nguvictor we don't use the neutral mostly, maybe base-200? also please review #128 I'm updating colors there to reflect figma more.
Maybe use js import (import the js object from
tailwind.config.js
instead of hard-copying?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base-200 wasn't visible even after adjusting to #191B1D found in #128
primary-content was way too strong
secondary-content seems about right