Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mean input in allocation #1427

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Use mean input in allocation #1427

merged 5 commits into from
Apr 25, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Apr 24, 2024 •
edited
Loading

Fixes #1121.

To do:

  • Use average source flows
  • Use average vertical fluxes on basin for level demand
  • Update documentation

@SouthEndMusic SouthEndMusic marked this pull request as draft April 24, 2024 08:18
@SouthEndMusic SouthEndMusic mentioned this pull request Apr 24, 2024
Closed
@SouthEndMusic
Copy link
Collaborator Author

Basin.demand does not have to be a dense vector, is it worth it to make this a sparse vector/dict?

@SouthEndMusic
Copy link
Collaborator Author

The last commit also removes all variables and constraints from the allocation problems for basins that do not have a level demand.

@SouthEndMusic SouthEndMusic marked this pull request as ready for review April 24, 2024 14:27
@SouthEndMusic SouthEndMusic requested a review from visr April 24, 2024 14:27
@visr visr merged commit 3ea6ac6 into main Apr 25, 2024
24 checks passed
@visr visr deleted the averages_for_allocation branch April 25, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use averaged source flows and basin forcings in allocation
2 participants
@SouthEndMusic @visr