Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter TabulatedRatingCurve validation #1469

Merged
merged 3 commits into from
May 21, 2024
Merged

Stricter TabulatedRatingCurve validation #1469

merged 3 commits into from
May 21, 2024

Conversation

visr
Copy link
Member

@visr visr commented May 14, 2024 •
edited
Loading

Fixes a part of #279.

The four checks added here are:

  • At least two datapoints are needed.
  • The flow_rate must start at 0.
  • The level cannot be repeated.
  • The flow_rate cannot decrease with increasing level.

And additionally we now ensure that flow rates are kept at 0 for levels below the minimum.

I should still check the docs, they may need some updating. The other part of #279 is best done in a separate PR as it relates to the Basin / profile table.

@visr visr mentioned this pull request May 14, 2024
Closed
7 tasks
@visr visr marked this pull request as ready for review May 14, 2024 20:59
SouthEndMusic
SouthEndMusic approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good

@visr @SouthEndMusic
Update docs/core/usage.qmd
671fedd 
Co-authored-by: Bart de Koning <[email protected]>
@visr visr merged commit 224c460 into main May 21, 2024
20 of 21 checks passed
@visr visr deleted the qh_check branch May 21, 2024 09:51
@visr visr mentioned this pull request May 21, 2024
Merged
SouthEndMusic pushed a commit that referenced this pull request May 21, 2024
@visr
Stronger 'Basin / profile' validation (#1486)
2041ddf 
Fixes #279.
Follow up of #1469.

Most rules were already in place, this just adds a bit more validation.
I moved the validation out of the constructor to be more in line with
the other validation taking place.
@SouthEndMusic SouthEndMusic mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouthEndMusic SouthEndMusic SouthEndMusic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visr @SouthEndMusic