Update natural-flow.ipynb #1916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the text a little, otherwise the different averages from different datasets may cause confusion by users.
visr
reviewed
Oct 22, 2024
Comment on lines
+92
to
+94
| "Reference the paths of the Ribasim installation and model directory and define the time period. \n" | ||
| "The used simulation period is defined by the `starttime` and `endtime` of the model, not by the input timeseries. \n" | ||
| "For now we will look into the years from 2022-01-01 until 2023-01-01 for the model simulation.\n", |
There was a problem hiding this comment.
Suggested change
| "Reference the paths of the Ribasim installation and model directory and define the time period. \n" | |
| "The used simulation period is defined by the `starttime` and `endtime` of the model, not by the input timeseries. \n" | |
| "For now we will look into the years from 2022-01-01 until 2023-01-01 for the model simulation.\n", | |
| "Reference the paths of the Ribasim installation and model directory and define the time period.\n", | |
| "The used simulation period is defined by the `starttime` and `endtime` of the model, not by the input timeseries.\n", | |
| "For now we will look into the period from 2022-01-01 until 2023-01-01 for the model simulation.\n", |
Comment on lines
+122
to
+123
| "The .csv file provided in the .zip folder contains the monthly inflow timeseries from 2014 to 2023.\n", | ||
| "You could read the .csv directly as a dataframe or add the flows between 2022 and 2023 manually as follows: " |
There was a problem hiding this comment.
The CSV file or ZIP is no longer introduced.
Merged
|
I'm closing this in favor of #1951. Thanks for the contribution! |
SouthEndMusic
pushed a commit
that referenced
this pull request
Dec 2, 2024
Replaces #1916, which had some issue with invalid JSON because it was edited in a text editor rather than a notebook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the text a little, otherwise the different averages from different datasets may cause confusion by users.
Fixes #