Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update natural-flow.ipynb #1916

Closed
wants to merge 1 commit into from
Closed

Update natural-flow.ipynb #1916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions docs/tutorial/natural-flow.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"source": [
"# Crystal River Basin\n",
"We will examine a straightforward example of the Crystal river basin, which includes a main river and a single tributary flowing into the sea (see @fig-crystal-basin).\n",
"An average discharge of $44.45 \\text{ m}^3/\\text{s}$ is measured at the confluence.\n",
"Between 2014 and 2023 the average discharge of $44.45 \\text{ m}^3/\\text{s}$ is measured at the confluence.\n",
"In this module, the basin is free of any activities, allowing the model to simulate the natural flow.\n",
"The next step is to include a demand (irrigation) that taps from a canal out of the main river.\n",
"\n",
Expand Down Expand Up @@ -89,7 +89,9 @@
"metadata": {},
"source": [
"### Setup paths and model configuration\n",
"Reference the paths of the Ribasim installation and model directory and define the time period (2022-01-01 until 2023-01-01) for the model simulation.\n",
"Reference the paths of the Ribasim installation and model directory and define the time period. \n"
"The used simulation period is defined by the `starttime` and `endtime` of the model, not by the input timeseries. \n"
"For now we will look into the years from 2022-01-01 until 2023-01-01 for the model simulation.\n",
Comment on lines +92 to +94
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Reference the paths of the Ribasim installation and model directory and define the time period. \n"
"The used simulation period is defined by the `starttime` and `endtime` of the model, not by the input timeseries. \n"
"For now we will look into the years from 2022-01-01 until 2023-01-01 for the model simulation.\n",
"Reference the paths of the Ribasim installation and model directory and define the time period.\n",
"The used simulation period is defined by the `starttime` and `endtime` of the model, not by the input timeseries.\n",
"For now we will look into the period from 2022-01-01 until 2023-01-01 for the model simulation.\n",

"The coordinate reference system (CRS) is also required, and set to [EPSG:4326](https://epsg.io/4326), which means all coordinates are interpreted as latitude and longitude values.\n",
"The CRS is important for correctly placing Ribasim models on the map, but since this is a fictional model, it is not important."
]
Expand Down Expand Up @@ -117,8 +119,8 @@
"source": [
"### FlowBoundary nodes\n",
"The Crystal basin consists of two inflow points, the tributary and the main Crystal river, we will call them Minor and Main respectively.\n",
"This is a monthly inflow timeseries from 2014 to 2023.\n",
"The used simulation period is defined by the `starttime` and `endtime` of the model, not by the input timeseries."
"The .csv file provided in the .zip folder contains the monthly inflow timeseries from 2014 to 2023.\n",
"You could read the .csv directly as a dataframe or add the flows between 2022 and 2023 manually as follows: "
Comment on lines +122 to +123
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSV file or ZIP is no longer introduced.

]
},
{
Expand All @@ -135,8 +137,8 @@
"data[\"total\"] = data[\"minor\"] + data[\"main\"]\n",
"display(data)\n",
"\n",
"# Average and max inflow of the total inflow data timeseries\n",
"# From 2014 - 2023\n",
"# Average and max inflow of the total inflow data implemented\n",
"# From 2022 - 2023\n",
"print(\"Average inflow [m3/s]:\", data[\"total\"].mean())\n",
"print(\"Maximum inflow [m3/s]:\", data[\"total\"].max())\n",
"\n",
Expand Down
Loading