Add name as column and use as visualisation in QGIS. #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
reviewed
Oct 9, 2023
visr
approved these changes
Oct 10, 2023
This was referenced Oct 19, 2023
Merged
visr
added a commit
that referenced
this pull request
Oct 25, 2023
Fixes #175 Most of the work for this was already done in #658. This changes a few things: - Stop using brackets around the ID to reduce visual clutter: now we use `"Lake IJssel" #10` in printed errors and `Lake IJssel #10` as a QGIS label - Add the edge ID to the label, this is the part that fixed #175 - Stop putting random strings as names in our basic test model - Add some real names to our Dutch waterways test model 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567