rename model files #690
Merged
rename model files #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofer-Julian
approved these changes
Oct 21, 2023
Merged
visr
added a commit
that referenced
this pull request
Oct 25, 2023
Fixes a large part of #638. Not entirely, I listed two follow-ups that are probably best done after #630 in that issue. This also removes the model name from the model, as before the only thing it did was name the TOML and GeoPackage. That meant I had to adapt `ribasim_testmodels` a bit to expose a `constructors` dict which maps the test model names to the constructor functions. https://github.com/Deltares/Ribasim/compare/names?expand=1#diff-b223bf31f9400e170f97d95fa1d8b22393e5d37cfd810a4a5aa7bf480915ac52 This doesn't just change the file names but also updates the documentation to stop talking about GeoPackage so much and consistently refer to the database. Also QGIS panel names are updated, function, class and variable names. TOML section names are updated, so this is breaking. Specifically, the `geopackage` key is now called `database`, and the `[output]` section is now called `[results]`. The default output folder is now also called results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a large part of #638. Not entirely, I listed two follow-ups that are probably best done after #630 in that issue.
This also removes the model name from the model, as before the only thing it did was name the TOML and GeoPackage.
That meant I had to adapt
ribasim_testmodelsa bit to expose aconstructorsdict which maps the test model names to the constructor functions.https://github.com/Deltares/Ribasim/compare/names?expand=1#diff-b223bf31f9400e170f97d95fa1d8b22393e5d37cfd810a4a5aa7bf480915ac52
This doesn't just change the file names but also updates the documentation to stop talking about GeoPackage so much and consistently refer to the database. Also QGIS panel names are updated, function, class and variable names.
Breaking changes
TOML section names are updated, so this is breaking. Specifically, the
geopackagekey is now calleddatabase, and the[output]section is now called[results]. The default output folder is now also called results.