Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODULAR] Announcer Reflavor #157

Merged
merged 5 commits into from
Oct 27, 2024

Conversation

W4rd3nn
Copy link

@W4rd3nn W4rd3nn commented Oct 13, 2024

About The Pull Request

The default announcer is cool and all but its ancient at this point and doesn't really suit the roleplay atmosphere much. I made this new one based on open source TTS and FL studio. It's meant to evoke a more industrial, cheaper feeling rather than a high tech space age AI voice. This also changes alert sounds and some language regarding the alerts themselves.

  • aimalf
  • alert
  • aliens
  • animes
  • commandreport
  • gravanomalies
  • intercept
  • ionstorm
  • meteors
  • outbreak5
  • outbreak7
  • poweroff
  • poweron
  • radiation
  • shuttle_called
  • shuttle_docked
  • shuttle_recalled
  • spanomalies
  • arrival
  • welcome

Some examples
https://discord.com/channels/1265752708812374066/1269986746028785789/1295897084066791544

Why It's Good For The Game

Most roleplay servers create their own announcers. We shouldn't be much different.

Changelog

🆑Motho
add: Changed some wording on the alert level configs
sound: Added new sound effects to replace the old default announcer.
sound: Changed the welcome sound that plays for latejoiners.
sound: Changed the roundstart sound.
/:cl:

@W4rd3nn W4rd3nn marked this pull request as ready for review October 16, 2024 00:31
@W4rd3nn W4rd3nn changed the title [DRAFT] [MODULAR] Announcer Reflavor [MODULAR] Announcer Reflavor Oct 16, 2024
@carpotoxin
Copy link
Collaborator

Most of these get too loud/crass for my ears. Some compression/peak limiting would work nicely.

@W4rd3nn
Copy link
Author

W4rd3nn commented Oct 16, 2024

Thats strange. They are all compressed, limited, and have their gain lowered to match the dB of the originals. They shouldnt be any louder than whats already in the game.

@SylvetteSylph
Copy link
Collaborator

SylvetteSylph commented Oct 17, 2024

I mentioned this before in the dev chat as this was being produced and it was kinda hand-waived and I was just told to wait until its in-game, but, the announcement sounds & TTS really really grate my ears. I'm now more confident than ever after this testmerge that these sounds need to get reworked.

@tf-4
Copy link

tf-4 commented Oct 17, 2024

It's kind of hard to understand what they're saying in the examples provided

@W4rd3nn
Copy link
Author

W4rd3nn commented Oct 18, 2024

I think I'll just add a volume mixer to the preferences tab. There was a pr to do it upstream but it got closed so ill just port it down here methinks

Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Oct 26, 2024
Copy link

@CliffracerX CliffracerX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody else has any problems with it, I'm speedmerging this, the announcer is peam

@github-actions github-actions bot removed the Stale label Oct 27, 2024
@CliffracerX CliffracerX merged commit 291b948 into DopplerShift13:master Oct 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants