Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banishes the entire crew to being in a group chat together #205

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

00-Steven
Copy link

@00-Steven 00-Steven commented Oct 29, 2024

About The Pull Request

In this pr we make it so every PDA begins with the NTRNC chatroom client, and add a common chatroom every crewmember is added to when they arrive on the station.
Additionally, this allows for setting a default username which will automatically be set for you before the channel join message runs.

To accommodate for this, common chatrooms such as this one cannot have a password set on them, in addition to the default behaviour of not being allowed to be deleted or renamed. They can also not have an operator account set.
Netadmins, IDs with ACCESS_NETWORK, can still mute people currently.

I'm leaving it as NTNRC for now, as we haven't done an NTNRC nor NtOS sweep yet, but updating this would just be changing a single define.

Why It's Good For The Game

bootleg irc my beloved
something something progress on the common removal or something
imma be real i just think it's fun 👍

Changelog

🆑
add: Every PDA now starts with the NTNRC chat client.
add: The NTNRC chat client has a new common #general channel, which every crewmember gets added to upon joining the station.
add: A new NTNRC username preference has been added to the names menu. Your NTNRC username is automatically set to this value.
add: NTNRC now works in low-power mode. When your PDA is in low-power mode, trying to close the program swaps between messenger and NTNRC.
qol: Opening the NTNRC chat client will auto-open the common channel, if you haven't left it.
/:cl:

@00-Steven
Copy link
Author

as requested:

  • chat client now starts open and on the common chat when you join
    (doesn't open the ui, just means that when you use your PDA for the first time it starts open)
    (doesn't work for latejoiners, as there's no ntnet on the shuttle)
  • if you haven't left the common chat, opening the chat client opens into the common chat
  • chat client now works in low power mode
  • exiting a program in low power mode now swaps between messenger and chat client

@00-Steven
Copy link
Author

me when automatic review requests
last commit just removes the program kills so it backgrounds ntnrc and the idle ntnrc new message header actually displays when you have messenger open in low power mode

Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Nov 16, 2024
@Nerev4r Nerev4r merged commit fb31333 into DopplerShift13:master Nov 20, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants