Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM ONLY] Hotfix belt loadout eating PDA prefs, if there's a belt PDA it goes into left pocket and that goes into bacpack #209

Closed
wants to merge 3 commits into from

Conversation

00-Steven
Copy link

@00-Steven 00-Steven commented Nov 1, 2024

About The Pull Request

See title.
Belt loadouts were overriding job outfit belt PDAs going into the belt slot and thus blocking prefs from being set to them.

Why It's Good For The Game

Test rounds less jank around the things we're actually testing.

Changelog

🆑
fix: If your job has a PDA on the belt, PDA goes into the left pocket (which goes into your backpack instead) so it doesn't eat your PDA prefs.
/:cl:

@00-Steven 00-Steven changed the title [TM ONLY] Hotfix belt loadout eating PDA prefs, if there's a belt PDA loadout belt goes into backpack [TM ONLY] Hotfix belt loadout eating PDA prefs, if there's a belt PDA it goes into left pocket and that goes into bacpack Nov 2, 2024
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Nov 10, 2024
@00-Steven
Copy link
Author

shoo stale shoo

Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Nov 19, 2024
@github-actions github-actions bot closed this Nov 26, 2024
@00-Steven
Copy link
Author

grahh

@Ephemeralis
Copy link
Collaborator

With this character's death, the thread of prophecy is severed. Restore a saved game to restore the weave of fate, or persist in the doomed world you have created.

Copy link

github-actions bot commented Dec 4, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants