NFC loading and storing implementation for Achievement Rally #1043
Conversation
# Conflicts: # app-android/src/main/java/io/github/droidkaigi/confsched2023/KaigiApp.kt
|
Snapshot diff report
|
momomomo111
changed the title
| if (uiState.isResetButtonEnabled) { | ||
| item( | ||
| key = "reset_button", | ||
| span = { GridItemSpan(SingleItemSpanCount) }, | ||
| ) { | ||
| Button( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| onClick = onReset, | ||
| ) { | ||
| Text(text = "Reset") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This button is no longer included in the version of the release
| val intent = Intent(this, MainActivity::class.java) | ||
| startActivity(intent) | ||
| finish() |
There was a problem hiding this comment.
If NFC reading fails, the default screen will be activated
app-android/src/main/java/io/github/droidkaigi/confsched2023/ResolveDynamicLinksActivity.kt
Outdated
Show resolved
Hide resolved
app-android/src/main/java/io/github/droidkaigi/confsched2023/ResolveDynamicLinksActivity.kt
Show resolved
Hide resolved
app-android/src/main/java/io/github/droidkaigi/confsched2023/ResolveDynamicLinksActivity.kt
Show resolved
Hide resolved
| deepLink = intent.data.toString(), | ||
| onFinished = { | ||
| val intent = Intent(this, MainActivity::class.java) | ||
| startActivity(intent) |
There was a problem hiding this comment.
Please consider the desired transitions after the animation finishes.
Currently, CompleteAchievementActivity will be visible when a user presses a back key on MainActivity. And then, if a user rotates their device, the animation restarts and show up MainActivity again.
MainActivity <- visible
CompleteAchievementActivity
// back key is pressed
CompleteAchievementActivity <- visible
// rotate their device
MainActivity <- visible
CompleteAchievementActivity
We have two options.
- Just finish CompleteAchievementActivity right after the animation finishes.
- Change the activity stack in the first place.
1. is so easy.
MainActivity <- visible
For 2, we can call startActivities(MainActivity's intent, CompleteAchievementActivity's intent in ResolveDynamicLinksActivity, and allow CompleteAchievementActivity not to launch MainActivity and not to finish. The final state of activity stacks will be like the following:
CompleteAchievementActivity <- visible
MainActivity
There was a problem hiding this comment.
Am I correct in recognizing that finishAndRemoveTask() is called after reading MainActivity?🤔
I actually tried pressing the back key after reading NFC and transitioning to MainActivity and the stack was cleared.
There was a problem hiding this comment.
Fixed in this commit.🙏
|
|
||
| fun onReachAnimationEnd() { | ||
| viewModelScope.launch { | ||
| achievementRepository.saveAchievements(animationLottieRawResStateFlow.value.first) |
There was a problem hiding this comment.
I think this can be dangerous. This is because the app finishes just after viewModelScope.launch(). So this block can be canceled.
I recommend saving this in onReadDeeplinkHash()
There was a problem hiding this comment.
Fixed in the following commit🙏
|
@momomomo111 |
| ) | ||
| } | ||
| if (uiState.isResetButtonEnabled) { |
There was a problem hiding this comment.
Can we merge this implementation?
There was a problem hiding this comment.
@momomomo111 I'm wondering if this button will be released.
|
I don't check if this works and we don't have any tests for this. Please check it by yourself 🙇 |
|
Hi @takahirom! Codes seem to be unformatted. To resolve this issue, please run |
I confirmed that A through E actually work after testing them.🙏 |
|
I'm not sure if @jmatsu is comfortable with this PR. I believe we can address any issues post-merge. Please let @momomomo111 know if there are any concerns. |
Issue
Overview (Required)
$ adb shell am start -W -a android.nfc.action.NDEF_DISCOVERED -d "https://confsched2023.page.link/e" io.github.droidkaigi.confsched2023.devThe Compose part of the CompleteAchievementActivity has been added to a module called Animation.
Movie (Optional)
demo.mp4