[Android] Enable to get version name from BuildConfig on AboutScreen

[syarihu]

Issue

• No issue

Overview (Required)

• Enable to get the version name from BuildConfig on AboutScreen. This eliminates the need to get the version name from Context

Detail

• Create a BuildConfigProvider interface to enable provision of BuildConfig values
• Create an AppModule to get the app version name from BuildConfig and pass it to BuildConfigProvider
• Added version name to AboutScreenUiState, which was unused, and made UiState available
• Added process to ViewModel to get app version name from BuildConfigProvider and set it to UiState
• Replaced the part of getting the app version name from Context with getting it from UiState
• The function to get the version name from Context is no longer needed, so it was removed

Links

• Nothing

Screenshot (Optional if screenshot test is present or unrelated to UI)

• Ensure results remain the same

Before	After

[github-actions]

Hi @syarihu! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

[takahirom]

We've attempted this. However, there's an issue where the tests can't recognize the Dagger Module of the app-android module. I believe the tests will fail. 😭
#782

[syarihu]

@takahirom
Thanks for sharing about your previous issues.
I have created a BuildConfigProviderModule that provides an empty BuildConfigProvider that can override the Provider using BindsOptionalOf in the data module.
Then, by overriding that setting in the AppModule, app-android was able to return values from BuildConfig while providing an empty BuildConfigProvider in the test.
I think this also makes all the test code PASS. In my environment, I passed all of them.
What do you think of this?

[github-actions]

Snapshot diff report

File name	Image
AboutScreenTest.chec kScrollShot_3_compar e.png
AboutScreenTest.chec kScrollShot_2_compar e.png

[github-actions]

Test Results

211 tests   211 ✔️  7m 49s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 4db99a1.

[takahirom]

👍

[takahirom]

@matsumo0922 For your reference, the issue is fixed now! 👍

[takahirom]

I have never used the BindsOptionalOf! Thanks

[syarihu]

Thanks for your review and merge!