Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Enable to get version name from BuildConfig on AboutScreen #1113

Merged
merged 11 commits into from
Sep 8, 2023
Merged

[Android] Enable to get version name from BuildConfig on AboutScreen #1113

merged 11 commits into from
Sep 8, 2023

Commits on Sep 7, 2023

  1. Add BuildConfigProvider to :core:model for get versionName from Build… 

    …Config
    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    f6a78b3 View commit details
    Browse the repository at this point in the history

  2. Add AppModule to app-android module to provide BuildConfig from app

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2013277 View commit details
    Browse the repository at this point in the history

  3. Make it possible to get version name from UiState

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    bbfc008 View commit details
    Browse the repository at this point in the history

  4. Stop getting version name from Context and get version name from UiState

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1168c8d View commit details
    Browse the repository at this point in the history

  5. Removed function to get version name from Context

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    7e64c3b View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary codes

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    f198f4b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into fix_method_of_getting_version_names

    @syarihu
    syarihu authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    bcddb29 View commit details
    Browse the repository at this point in the history

  8. The data module should have a HiltModule that provides a BuildConfigP… 

    …rovider. Then, overwrite the provider with android-app module so that both testing module and android-app module can handle BuildConfigProvider
    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6e95950 View commit details
    Browse the repository at this point in the history

  9. Reformat by detekt

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    dd0c93f View commit details
    Browse the repository at this point in the history

  10. Fix hilt module name

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    01ddea8 View commit details
    Browse the repository at this point in the history

  11. Define EmptyBuildConfigProvider

    @syarihu
    syarihu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    4db99a1 View commit details
    Browse the repository at this point in the history