Changed to not include Firebase implementation on the iOS side #580
Conversation
iOS側にFirebaseの実装を入れないように変更
| @@ -159,6 +160,8 @@ class RemoteConfigModule { | |||
| @Provides | |||
| @Singleton | |||
| fun provideFirebaseRemoteConfig(): RemoteConfigApi { | |||
| return DefaultRemoteConfigApi() | |||
There was a problem hiding this comment.
We can move DefaultRemoteConfigApi to androidMain and you can leave this providing DefaultRemoteConfigApi as it is 🙏
There was a problem hiding this comment.
DefaultRemoteConfigApi is in commonMain currently. I would like you to bring it to androidMain 🙏
There was a problem hiding this comment.
I was able to confirm the operation and get a normal value.
There was a problem hiding this comment.
It's not for Andorid but for iOS 🙏
When iOS use DefaultRemoteConfigApi, DefaultRemoteConfigApi don't have the implementation class right?
Also can you check this?
./gradlew :app-ios-shared:assembleSharedReleaseXCFramework
There was a problem hiding this comment.
Fully understood 🙆♂️
./gradlew :app-ios-shared:assembleSharedReleaseXCFramework also confirms that the build passes!
DefaultRemoteConfigApiを返すように変更
|
|
||
| import io.github.droidkaigi.confsched2023.data.remoteconfig.FakeRemoteConfigApi.Status.Default | ||
|
|
||
| actual class DefaultRemoteConfigApi : RemoteConfigApi { |
There was a problem hiding this comment.
I don't think we should make this class because iOS engineers will use this and won't notice if they use fake👀
Overview (Required)
Links