-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed to not include Firebase implementation on the iOS side #580
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4626466
Changed to not include Firebase implementation on the iOS side
momomomo111 07e9400
Changed to return DefaultRemoteConfigApi
momomomo111 15a626d
Changed so that the key is passed across.
momomomo111 38b4373
Changed so that the key is passed across.
momomomo111 200463e
Revert "Changed so that the key is passed across."
momomomo111 a1621d5
Changed so that the key is passed across.
momomomo111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...ain/kotlin/io/github/droidkaigi/confsched2023/data/remoteconfig/DefaultRemoteConfigApi.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package io.github.droidkaigi.confsched2023.data.remoteconfig | ||
|
||
import dev.gitlive.firebase.Firebase | ||
import dev.gitlive.firebase.remoteconfig.get | ||
import dev.gitlive.firebase.remoteconfig.remoteConfig | ||
|
||
actual class DefaultRemoteConfigApi : RemoteConfigApi { | ||
|
||
private val firebaseRemoteConfig = Firebase.remoteConfig | ||
|
||
/** | ||
* If you want to change the interval time to fetch, please change it here | ||
*/ | ||
// init { | ||
// CoroutineScope(Dispatchers.IO).launch { | ||
// firebaseRemoteConfig.settings { | ||
// minimumFetchIntervalInSeconds = 12 * 3600L | ||
// } | ||
// } | ||
// } | ||
|
||
actual override suspend fun getBoolean(key: String): Boolean { | ||
firebaseRemoteConfig.fetchAndActivate() | ||
return firebaseRemoteConfig[key] | ||
} | ||
} |
25 changes: 2 additions & 23 deletions
25
...ain/kotlin/io/github/droidkaigi/confsched2023/data/remoteconfig/DefaultRemoteConfigApi.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,5 @@ | ||
package io.github.droidkaigi.confsched2023.data.remoteconfig | ||
|
||
import dev.gitlive.firebase.Firebase | ||
import dev.gitlive.firebase.remoteconfig.get | ||
import dev.gitlive.firebase.remoteconfig.remoteConfig | ||
|
||
class DefaultRemoteConfigApi : RemoteConfigApi { | ||
|
||
private val firebaseRemoteConfig = Firebase.remoteConfig | ||
|
||
/** | ||
* If you want to change the interval time to fetch, please change it here | ||
*/ | ||
// init { | ||
// CoroutineScope(Dispatchers.IO).launch { | ||
// firebaseRemoteConfig.settings { | ||
// minimumFetchIntervalInSeconds = 12 * 3600L | ||
// } | ||
// } | ||
// } | ||
|
||
override suspend fun getBoolean(key: String): Boolean { | ||
firebaseRemoteConfig.fetchAndActivate() | ||
return firebaseRemoteConfig[key] | ||
} | ||
expect class DefaultRemoteConfigApi : RemoteConfigApi { | ||
override suspend fun getBoolean(key: String): Boolean | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
...ain/kotlin/io/github/droidkaigi/confsched2023/data/remoteconfig/DefaultRemoteConfigApi.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package io.github.droidkaigi.confsched2023.data.remoteconfig | ||
|
||
import io.github.droidkaigi.confsched2023.data.remoteconfig.FakeRemoteConfigApi.Status.Default | ||
|
||
actual class DefaultRemoteConfigApi : RemoteConfigApi { | ||
|
||
actual override suspend fun getBoolean(key: String): Boolean { | ||
return FakeRemoteConfigApi().apply { | ||
setUp(Default) | ||
}.getBoolean(key) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should make this class because iOS engineers will use this and won't notice if they use fake👀