Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update background color of the top area of the timetable screen #586

Conversation

Masaki-U
Copy link
Contributor

@Masaki-U Masaki-U commented Aug 16, 2023

Issue

Overview (Required)

  • update background color of the top area of the timetable screen
  • TopAppBar title icon now change color in light and dark mode respectively.

Link

Screenshot

Before After

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Test Results

49 tests   49 ✔️  2m 57s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 99406c4.

♻️ This comment has been updated with latest results.

@momomomo111
Copy link
Contributor

momomomo111 commented Aug 16, 2023

@Masaki-U Thank you for your contribution!

Could you please change the title of the Pull Request to make it more understandable?🙏

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 16, 2023 17:24 Inactive
@github-actions
Copy link

Hi @Masaki-U! Codes seem to be unformatted. To resolve this issue, please run ./gradlew spotlessKotlinApply and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 16, 2023 19:03 Inactive
@@ -34,7 +33,7 @@ fun TimetableTopArea(
) {
TopAppBar(
title = {
Image(
Icon(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

private val timetableTopBackgroundDark = Color(0xFF2D4625)

@Composable
@ReadOnlyComposable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your cool pull request!

@takahirom takahirom merged commit 8594099 into DroidKaigi:main Aug 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update background color of the top area of the timetable screen.
3 participants