-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update background color of the top area of the timetable screen #586
Merged
takahirom
merged 8 commits into
DroidKaigi:main
from
Masaki-U:feature/UpdateBackgroundColorOfTheTopAreaOfTheTimetableScreen
Aug 17, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
450bf26
Change the background color of the timetable's Scaffold to transparent.
Masaki-U 9114205
Create the light and dark background colors for the timetable screen.
Masaki-U af8b3d9
Create a light and dark mode preview for the timetable screen.
Masaki-U 547cbd8
Apply a gradient to the background color of the timetable's Scaffold.
Masaki-U 8eedce4
[Fix]Fix the issue where the theme color is not applied to the Leadin…
Masaki-U 6ca74ec
[Refactor]Apply the status bar padding to the preview.
Masaki-U bf654dc
Add handling for the gradient endpoint in landscape mode.
Masaki-U 99406c4
code format
Masaki-U File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,17 @@ | ||
package io.github.droidkaigi.confsched2023.sessions.component | ||
|
||
import androidx.compose.foundation.Image | ||
import androidx.compose.material.icons.Icons | ||
import androidx.compose.material.icons.filled.GridView | ||
import androidx.compose.material.icons.filled.Search | ||
import androidx.compose.material.icons.outlined.Bookmarks | ||
import androidx.compose.material3.ExperimentalMaterial3Api | ||
import androidx.compose.material3.Icon | ||
import androidx.compose.material3.IconButton | ||
import androidx.compose.material3.MaterialTheme | ||
import androidx.compose.material3.TopAppBar | ||
import androidx.compose.material3.TopAppBarDefaults | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.graphics.Color | ||
import androidx.compose.ui.platform.testTag | ||
import androidx.compose.ui.res.painterResource | ||
import io.github.droidkaigi.confsched2023.feature.sessions.R | ||
|
@@ -34,7 +33,7 @@ fun TimetableTopArea( | |
) { | ||
TopAppBar( | ||
title = { | ||
Image( | ||
Icon( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
painter = painterResource(id = R.drawable.icon_droidkaigi_logo), | ||
contentDescription = null, | ||
) | ||
|
@@ -70,7 +69,7 @@ fun TimetableTopArea( | |
} | ||
}, | ||
colors = TopAppBarDefaults.largeTopAppBarColors( | ||
containerColor = MaterialTheme.colorScheme.surfaceVariant, | ||
containerColor = Color.Transparent, | ||
), | ||
) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒