Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply adaptive icon #616

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Conversation

rocoand
Copy link
Contributor

@rocoand rocoand commented Aug 17, 2023

Issue

Overview (Required)

  • add ic_launcher_background.png and ic_launcher_foreround.png
  • create ic_launcher.xml in res/mipmap-anydpi-v26

Links

Screenshot

Before After

Comment on lines 1 to 5
<?xml version="1.0" encoding="utf-8"?>
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android">
<background android:drawable="@mipmap/ic_launcher_background" />
<foreground android:drawable="@mipmap/ic_launcher_foreground" />
</adaptive-icon>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented like this, but the foreground image is bigger than before.
Could you tell me how to fix this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used Image Asset to create the adaptive icon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your adjustment!

@rocoand
Copy link
Contributor Author

rocoand commented Aug 17, 2023

I used Image Asset to create the adaptive icon and it seems to fix this problem

@rocoand rocoand marked this pull request as ready for review August 17, 2023 09:55
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Test Results

74 tests   74 ✔️  4m 1s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 723119c.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 17, 2023 10:22 Inactive
@rocoand rocoand changed the title [WIP]Apply adaptive icon Apply adaptive icon Aug 17, 2023
Copy link
Member

@takahirom takahirom Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tell me if we are using this while we are having vector drawable? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the wrong files! 🙏
I regenerated icons.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why we need this? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to delete it.
We won't release this app on the store this year either, right?
I will delete it!

Copy link
Member

@takahirom takahirom Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will release DroidKaigi app. But as far as I know, I don't think we have to put the image that is for Play Store's console into apk. If there is anything Play Store will use image in apk or something, let me know 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my answer was not accurate because I am a beginner and not knowledgeable 🙇‍♂️ (and last year I used DroidKaigi app from GitHub so I didn't know it was released 🙇‍♂️ sry)
This image don't need to release app, I learned ! 🙇‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's totally OK to try and learn from anything by trial and error! That's how we learn!

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 17, 2023 15:24 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for cooperation! Everyone in DroidKaigi will see this icon! 🙏

@takahirom takahirom merged commit 9781ad5 into DroidKaigi:main Aug 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptive Icon
2 participants