-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply adaptive icon #616
Apply adaptive icon #616
Conversation
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@mipmap/ic_launcher_background" /> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground" /> | ||
</adaptive-icon> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented like this, but the foreground image is bigger than before.
Could you tell me how to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used Image Asset to create the adaptive icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your adjustment!
I used Image Asset to create the adaptive icon and it seems to fix this problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you tell me if we are using this while we are having vector drawable? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted the wrong files! 🙏
I regenerated icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why we need this? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to delete it.
We won't release this app on the store this year either, right?
I will delete it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will release DroidKaigi app. But as far as I know, I don't think we have to put the image that is for Play Store's console into apk. If there is anything Play Store will use image in apk or something, let me know 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my answer was not accurate because I am a beginner and not knowledgeable 🙇♂️ (and last year I used DroidKaigi app from GitHub so I didn't know it was released 🙇♂️ sry)
This image don't need to release app, I learned ! 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's totally OK to try and learn from anything by trial and error! That's how we learn!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for cooperation! Everyone in DroidKaigi will see this icon! 🙏
Issue
Overview (Required)
ic_launcher_background.png
andic_launcher_foreround.png
ic_launcher.xml
inres/mipmap-anydpi-v26
Links
Screenshot