-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply adaptive icon #616
Merged
takahirom
merged 4 commits into
DroidKaigi:main
from
rocoand:feature/apply-adaptive-icon
Aug 17, 2023
Merged
Apply adaptive icon #616
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions
21
app-android/src/main/res/drawable-v24/ic_launcher_background.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:aapt="http://schemas.android.com/aapt" | ||
| android:width="108dp" | ||
| android:height="108dp" | ||
| android:viewportWidth="192" | ||
| android:viewportHeight="192"> | ||
| <path | ||
| android:pathData="M0,0h192v192h-192z"> | ||
| <aapt:attr name="android:fillColor"> | ||
| <gradient | ||
| android:startX="96" | ||
| android:startY="0" | ||
| android:endX="100.5" | ||
| android:endY="127.88" | ||
| android:type="linear"> | ||
| <item android:offset="0" android:color="#FFA9E5FF"/> | ||
| <item android:offset="1" android:color="#FFF6FFD3"/> | ||
| </gradient> | ||
| </aapt:attr> | ||
| </path> | ||
| </vector> |
17 changes: 17 additions & 0 deletions
17
app-android/src/main/res/drawable/ic_launcher_foreground.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="108dp" | ||
| android:height="108dp" | ||
| android:viewportWidth="192" | ||
| android:viewportHeight="192"> | ||
| <group android:scaleX="0.63" | ||
| android:scaleY="0.63" | ||
| android:translateX="35.52" | ||
| android:translateY="35.52"> | ||
| <path | ||
| android:pathData="M77.68,82.35L110.65,52.11C122.62,41.14 145.78,46.1 145.78,62.33V129.82C145.78,146.04 122.49,150.82 110.52,139.84L77.68,109.79C69.63,102.42 69.63,89.73 77.68,82.35Z" | ||
| android:fillColor="#48D597"/> | ||
| <path | ||
| android:pathData="M89.58,62.99L73.48,77.76C68.35,82.46 65.42,89.13 65.42,96.08C65.42,103.01 68.35,109.69 73.48,114.39L89.47,129.02L78.56,139.89C67.54,150.87 46.22,145.9 46.22,129.67V62.18C46.22,45.95 67.66,41.18 78.68,52.16L89.58,62.99Z" | ||
| android:fillColor="#18AFDE"/> | ||
| </group> | ||
| </vector> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@drawable/ic_launcher_background"/> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground"/> | ||
| </adaptive-icon> |
5 changes: 5 additions & 0 deletions
5
app-android/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@drawable/ic_launcher_background"/> | ||
| <foreground android:drawable="@drawable/ic_launcher_foreground"/> | ||
| </adaptive-icon> |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why we need this? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to delete it.
We won't release this app on the store this year either, right?
I will delete it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will release DroidKaigi app. But as far as I know, I don't think we have to put the image that is for Play Store's console into apk. If there is anything Play Store will use image in apk or something, let me know 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my answer was not accurate because I am a beginner and not knowledgeable 🙇♂️ (and last year I used DroidKaigi app from GitHub so I didn't know it was released 🙇♂️ sry)
This image don't need to release app, I learned ! 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's totally OK to try and learn from anything by trial and error! That's how we learn!