♻️ Enhanced StaffScreen testing. #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. modified to check if the elements of individual items are visible. 2. modified to check if the snack bar is displayed when an Exception occurs as in other tests.
…ther two or more staff are displayed.
…enhancement/staff_screen_test_enhancement # Conflicts: # feature/staff/src/commonMain/kotlin/io/github/droidkaigi/confsched/staff/StaffScreen.kt
|
@takahirom |
…enhancement/staff_screen_test_enhancement
takahirom
reviewed
Aug 18, 2024
| itShould("show first and second staffs") { | ||
| captureScreenWithChecks { | ||
| checkRangeStaffItemsDisplayed( | ||
| fromTo = 0..2, |
![StaffScreenTest[StaffScreen - when server is operational - when launch - when scroll to index 10 - it should show staffs]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/staff_screen_test_enhancement/./screenshot-diff-reports/feature/staff/build/outputs/roborazzi/StaffScreenTest%5BStaffScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20when%20scroll%20to%20index%2010%20-%20it%20should%20show%20staffs%5D_compare.png){kind=link}
![StaffScreenTest[StaffScreen - when server is operational - when launch - it should show first and second staffs]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/staff_screen_test_enhancement/./screenshot-diff-reports/feature/staff/build/outputs/roborazzi/StaffScreenTest%5BStaffScreen%20-%20when%20server%20is%20operational%20-%20when%20launch%20-%20it%20should%20show%20first%20and%20second%20staffs%5D_compare.png){kind=link}
![StaffScreenTest[StaffScreen - when server is operational - when server is down - when launch - it should does not show staff and show snackbar]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_enhancement/staff_screen_test_enhancement/./screenshot-diff-reports/feature/staff/build/outputs/roborazzi/StaffScreenTest%5BStaffScreen%20-%20when%20server%20is%20operational%20-%20when%20server%20is%20down%20-%20when%20launch%20-%20it%20should%20does%20not%20show%20staff%20and%20show%20snackbar%5D_compare.png){kind=link}
There was a problem hiding this comment.
How about making a method? I would like to hide implementations to Robots.
takahirom
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
xxxxScreenTesttests #464Overview (Required)