Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manufactured solution test group #72

Merged
merged 13 commits into from
Jun 19, 2023
Merged

Add manufactured solution test group #72

merged 13 commits into from
Jun 19, 2023

Conversation

cbegeman
Copy link
Collaborator

This PR adds the manufactured solution test group and the convergence test case as described in Bishnu et al.(2023). The test case depends on E3SM-Project/E3SM#5725. The test currently "fails" with a convergence rate of 0.9 rather than ~2 due to E3SM-Project/E3SM#5364.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes
  • New tests have been added to a test suite

@cbegeman cbegeman requested a review from sbrus89 May 26, 2023 19:49
@cbegeman cbegeman self-assigned this May 26, 2023
@cbegeman cbegeman added enhancement New feature or request ocean Related to ocean tests or analysis E3SM PR required The polaris changes won't work with the current E3SM-Project submodule and require an update labels May 26, 2023
@cbegeman
Copy link
Collaborator Author

Testing

This test case has been run with intel, open-mpi on chrysalis.

@cbegeman
Copy link
Collaborator Author

@sbrus89 Thank you for adding those doc strings!

@cbegeman cbegeman force-pushed the add-manufactured-solution-test branch 2 times, most recently from 329a319 to 964a065 Compare June 1, 2023 14:01
@cbegeman
Copy link
Collaborator Author

cbegeman commented Jun 1, 2023

These are the updated figures:
comparison
convergence

@cbegeman cbegeman force-pushed the add-manufactured-solution-test branch from 964a065 to 17b7aaf Compare June 1, 2023 16:23
@cbegeman
Copy link
Collaborator Author

cbegeman commented Jun 1, 2023

@sbrus89 I think this is ready to go in when the E3SM PR gets merged.

sbrus89
sbrus89 reviewed Jun 2, 2023
View reviewed changes
polaris/viz/__init__.py Outdated Show resolved Hide resolved
@sbrus89 sbrus89 mentioned this pull request Jun 7, 2023
Merged
@cbegeman cbegeman force-pushed the add-manufactured-solution-test branch from 17b7aaf to af0111f Compare June 8, 2023 21:14
@cbegeman
Copy link
Collaborator Author

cbegeman commented Jun 8, 2023

Thanks @sbrus89! I implemented your suggestions

@cbegeman
Copy link
Collaborator Author

cbegeman commented Jun 8, 2023

@xylar Are you seeing the python 3.8 CI test fail elsewhere?

@xylar
Copy link
Collaborator

xylar commented Jun 8, 2023

@cbegeman, no, I haven't seen that anywhere else. The other python checks might also fail, they just got cancelled before they got a chance.

@xylar
Copy link
Collaborator

xylar commented Jun 8, 2023

The error message wasn't super helpful but seemed like something that might not happen again if we rerun. Let's see what happens.

@xylar
Copy link
Collaborator

xylar commented Jun 9, 2023

Yep just seems to have needed a rerun.

@cbegeman cbegeman force-pushed the add-manufactured-solution-test branch from af0111f to 977e9ad Compare June 9, 2023 16:12
@sbrus89 sbrus89 mentioned this pull request Jun 9, 2023
Closed
sbrus89
sbrus89 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to merge once the E3SM submodule has been updated following the merge of E3SM-Project/E3SM#5725. Thanks @cbegeman!

@sbrus89 sbrus89 added E3SM PR finished The polaris changes required an update to the E3SM-Project submodule and this is now finished and removed E3SM PR required The polaris changes won't work with the current E3SM-Project submodule and require an update labels Jun 15, 2023
@cbegeman
Copy link
Collaborator Author

@xylar Are you ok with this merge? I just updated the e3sm submodule and retested the PR suite with all passes for existing tests.

@xylar
Copy link
Collaborator

xylar commented Jun 19, 2023

@cbegeman, sure, go for it!

@cbegeman cbegeman merged commit 380a7e9 into E3SM-Project:main Jun 19, 2023
altheaden pushed a commit to altheaden/polaris that referenced this pull request Jun 21, 2023
@cbegeman @altheaden
Merge pull request E3SM-Project#72 from cbegeman/add-manufactured-sol…
bfbf587 
…ution-test

Add manufactured solution test group

This PR adds the manufactured solution test group and the convergence test case as described in [Bishnu et al.(2023)](https://doi.org/10.22541/essoar.167100170.03833124/v1).
@xylar xylar deleted the add-manufactured-solution-test branch June 22, 2023 21:33
@altheaden altheaden mentioned this pull request Jun 22, 2023
Closed
This was referenced Oct 14, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrus89 sbrus89 sbrus89 approved these changes

Assignees

@cbegeman cbegeman

Labels
E3SM PR finished The polaris changes required an update to the E3SM-Project submodule and this is now finished enhancement New feature or request ocean Related to ocean tests or analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbegeman @xylar @sbrus89