Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 402: Manual curation fixes from October #412

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Issue 402: Manual curation fixes from October #412

merged 4 commits into from
Jan 31, 2024

Conversation

apriltuesday
Copy link
Contributor

@apriltuesday apriltuesday commented Jan 19, 2024 •
edited
Loading

Closes #402 - updates to replacement terms and manual curation SOP

Based on automated-mappings branch, see diff here

@apriltuesday apriltuesday marked this pull request as ready for review January 22, 2024 11:19
@apriltuesday apriltuesday self-assigned this Jan 22, 2024
@apriltuesday apriltuesday mentioned this pull request Jan 22, 2024
Closed
7 tasks
M-casado
M-casado approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@M-casado M-casado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noticed that ORDO is no longer to be imported, and obsolete terms will be recursively avoided till exhaustion 👍

docs/manual-curation/step2-manual-curation.md Outdated Show resolved Hide resolved
@apriltuesday
Copy link
Contributor Author

Thanks @M-casado, yes removing ORDO import is by request from EFO. I think we've avoided the dreaded infinite recursion with the max depth check, although if there's an infinite loop in the ontology replacement terms I have some questions 😅

@apriltuesday apriltuesday merged commit 5d3f000 into EBIvariation:master Jan 31, 2024
1 check passed
@apriltuesday apriltuesday deleted the issue-402 branch January 31, 2024 09:52
@M-casado
Copy link
Collaborator

Ah, my bad @apriltuesday, with "till exhaustion" I meant "till exhausting the variable" you set up 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-casado M-casado M-casado approved these changes

@tcezard tcezard tcezard approved these changes

Assignees

@apriltuesday apriltuesday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual curation fixes from October
3 participants
@apriltuesday @M-casado @tcezard