Feat: Delay the resumption of the message queue after reconnect #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me() and the actual resumption Signed-off-by: Valentin Dimov <[email protected]>
…n two Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
marcemmers
reviewed
Nov 29, 2023
marcemmers
reviewed
Nov 29, 2023
Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
… on boot Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
hikinggrass
approved these changes
Dec 7, 2023
Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
Signed-off-by: Valentin Dimov <[email protected]>
hikinggrass
approved these changes
Dec 7, 2023
valentin-dimov
deleted the
vd-delay-message-queue-resume-after-reconnect
branch
couryrr-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Dec 18, 2023
…nnect (EVerest#283) Signed-off-by: Valentin Dimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OCTT tests (as well as real CSMS) send certain requests to the charging station after a reconnect (e.g. checking transaction status) and expect the charging station to respond to them before emptying its message queue.
This PR adds a configurable delay between a reconnect and the resumption of the message queue. During this delay, the charging station can still respond to requests from the CSMS, but any outgoing requests will only be sent after the delay passes.