Fix potential state machine issue #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this->status->get_state(connector) == ChargePointStatus::Faulted since the internal state of the state machine could be other then Faulted, which would lead to an unspecified transaction not moving back to Available Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
bugfix/return-to-available-after-error
branch
from
360025f to
f460dce
Compare
hikinggrass
approved these changes
Nov 13, 2024
Pietfried
added a commit
that referenced
this pull request
Nov 14, 2024
…this->status->get_state(connector) == ChargePointStatus::Faulted since the internal state of the state machine could be other then Faulted, which would lead to an unspecified transaction not moving back to Available (#865) Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
added a commit
that referenced
this pull request
Nov 14, 2024
…this->status->get_state(connector) == ChargePointStatus::Faulted since the internal state of the state machine could be other then Faulted, which would lead to an unspecified transaction not moving back to Available (#865) Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
added a commit
that referenced
this pull request
Nov 25, 2024
…this->status->get_state(connector) == ChargePointStatus::Faulted since the internal state of the state machine could be other then Faulted, which would lead to an unspecified transaction not moving back to Available (#865) Signed-off-by: Piet Gömpel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a change that uses the transaction
BecomeAvailableinstead ofI1_ReturnToAvailableinsideon_session_stoppedalso when this->status->get_state(connector) == ChargePointStatus::Faulted since the internal state of the state machine could be other then Faulted, which would lead to an unspecified transition not moving back to Available.Issue ticket number and link
Checklist before requesting a review