-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create <Table />
spec
#535
Conversation
documentation/specs/DisplayTable.md
Outdated
```ts | ||
type DisplayTableProps = AriaLabelingProps & { | ||
/** Columns for the table. */ | ||
columns: Column[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for DisplayTable
, columns
and rows
follow a highly-specific data structure as noted in the type definitions below. this is a bit of a departure from our Table
component, where the actual cell data is largely arbitrary and the rendering is controlled by the consumer (via renderHeaderCell
, renderBodyCell
, etc).
i think (a) i wanted to try to match our current MarketingTable API as much as we could where reasonable; and (b) it seems like to me for a display table where so much of the styling is governed by the internals of the component itself, it makes sense for it to not to defer rendering to the consumer and instead opt for a specific data structure.
let me know if that makes sense and feels cohesive enough in our component library for having the two approaches, and/or if there are better ideas
This looks great! |
📝 Changes
<Table />
spec