Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): return focus to trigger after closing menu #550

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

stephenjwatkins
Copy link
Contributor

📝 Changes

  • uses Overlay instead of OverlayContainer to return focus back to trigger after closing menu. this is per Aria documentation and was simply missed in the implementation
  • attempted to write a unit test for this but couldn't get user event, jsdom, and Aria to play nicely together for this change. will come back to it when i figure out how to test focus in these cases

✅ Checklist

  • Code is complete and in accordance with our style guide
  • Ensure no accessibility violations are reported in Storybook
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

@stephenjwatkins stephenjwatkins marked this pull request as ready for review August 18, 2023 16:35
Copy link
Contributor

@ldewald ldewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@stephenjwatkins stephenjwatkins merged commit 9089d64 into main Aug 24, 2023
3 checks passed
@stephenjwatkins stephenjwatkins deleted the fix_menu_overlay branch August 24, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants