Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): support disabled actions #561

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

stephenjwatkins
Copy link
Contributor

📝 Changes

  • Passes through isDisabled prop to action buttons to support them being disabled
  • Adds some documentation to Storybook for this but felt it didn't need a full story or specific unit tests for this change

Note that with Easy UI we're moving to a more constraint-based design for components to promote consistency. That's why we're not blindly allowing any button prop to pass through the actions, because it can lead to unintended Modal styles. So for now we're listing specific props that are allowed to pass through.

✅ Checklist

  • Code is complete and in accordance with our style guide
  • Stories (docs) in Storybook accompany any relevant component changes
  • Ensure no accessibility violations are reported in Storybook
  • Specs and documentation are up-to-date
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

@stephenjwatkins stephenjwatkins merged commit 8fe2ca9 into main Aug 24, 2023
3 checks passed
@stephenjwatkins stephenjwatkins deleted the modal-disabled-btns branch August 24, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants