Stellar types #603
Merged
Stellar types #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
swansontec
force-pushed
the
william/stellar-types
branch
from
33d7b3d to
95ccc4d
Compare
samholmes
approved these changes
Aug 24, 2023
| @@ -687,8 +672,6 @@ export async function makeCurrencyEngine( | |||
| const safeWalletInfo = asSafeStellarWalletInfo(walletInfo) | |||
| const engine = new StellarEngine(env, tools, safeWalletInfo, opts) | |||
|
|
|||
| engine.stellarApi = stellarApi | |||
There was a problem hiding this comment.
That was smelly. Good cleanup. 👍
| @@ -30,6 +30,7 @@ import { | |||
| import { | |||
| getBalanceChanges, | |||
| OfferCreate, | |||
| Payment as PaymentJson, | |||
There was a problem hiding this comment.
I'll trust you that upstream Payment is a subtype of the removed PaymentJson
These are based on the code examples and on our own usage.
swansontec
force-pushed
the
william/stellar-types
branch
from
95ccc4d to
69d0f0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
noneDependencies
noneDescription
The code has been untyped for a while, which makes it hard to maintain and work with.