Paul/core2.0

[paullinator]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

#4677

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1206136700366060

[swansontec]

Besides the comments here, I have a sidecar branch that includes a bunch of additional fixes.

The sidecar branch focuses on the GuiCurrencyInfo and WalletListResult, which are using tokenId: undefined to mean both "parent currency" and "none specified". We aren't using null in general, but only to indicate parent currencies. This means we can't use tokenId: null to mean "none specified".

In the GuiCurrencyInfo case, I simply made the tokenId mandatory in all cases. In the WalletListResult case, I use a discriminated union to simply remove the tokenId when it is not relevant.

This branch will need to be rebased on top of the sidecar branch. The merge conflicts are things we need to fix in any case.

[swansontec]

Do not use setInterval! There are subtle dangers here. Use makePeriodicTask to handle this in a better way.

[swansontec]

I moved this fix to #4677

[swansontec]

A note about this one: I made EdgeParsedUri.tokenId optional, since it doesn't apply in all scenarios. For instance, something like a bitId URI would not include a currency code / tokenId at all.

More importantly, we would need to add upgrade logic into the core, in case an older currency plugin fails to pass tokenId, we can still derive it from the currency code so the GUI can rely on it being present. We don't want illegal values slipping past the type system, since that's a recipe for crashes.

I did not want to enter this minefield, so I'm leaving the status quo for now.

The correct fix is to make EdgeParsedUri a union type, reflecting the different types of things we might scan (payments / private keys / wallet connect / bitId / request for address / etc.), so we can make tokenId mandatory in the places where it matters. This is a bigger project, so I left it for another day.